pcp
[Top] [All Lists]

Re: [pcp] pcp updates: ipv6

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: ipv6
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 12 Mar 2013 23:42:14 -0400 (EDT)
Cc: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <513F5B3B.4050508@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Hi Dave,

----- Original Message -----
> 
> On 03/12/2013 05:24 AM, Nathan Scott wrote:
> >
> > ----- Original Message -----
> >> Similarly for qa/062.out ... if you have 062.out.1, 062.out.1234
> >> and
> >> 062.out.4321, then 062.out should not be there.
> >>
> >> And the same problem is evident for qa/499.out.
> >>
> >> And I'd expect to see 062.out and qa/499.out added to
> >> qa/.gitignore.
> >>
> > Hmmm, I'll leave these to Dave to review and sort out, I missed
> > those
> > on my glance over his changes this morning.
> >
> Sorry if I botched this. This was a deliberate change on my part. As
> far
> as I can tell, these tests are no longer IPv6 or endian dependant, so
> I
> removed the .1, .2, .1234 and .4321 variants of the output for these
> tests. They each now have a single .out. As such I also removed the
> .out
> for each test from .gitignore and commited them.

062 at least will need some associated changes in the test, so that
it does not try to create a .out file from .out.1 ... perhaps a file
missed in your commit (dev branch d3fc53fb)?

Thanks.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>