pcp
[Top] [All Lists]

Re: RFC: libpcp hash table iterators

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: RFC: libpcp hash table iterators
From: fche@xxxxxxxxxx (Frank Ch. Eigler)
Date: Fri, 08 Mar 2013 16:28:05 -0500
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1803062083.17410512.1362773975482.JavaMail.root@xxxxxxxxxx> (Nathan Scott's message of "Fri, 8 Mar 2013 15:19:35 -0500 (EST)")
References: <20130308164357.GC4559@xxxxxxxxxx> <1803062083.17410512.1362773975482.JavaMail.root@xxxxxxxxxx>
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)
Hi, Nathan -

> On review [...]

Please see the new & improved fche/hashiter branch commit, renamed &
tested.
http://sourceware.org/git/?p=pcpfans.git;a=commitdiff;h=b997f5945

> Also worth thinking about, the pmda caches avoid malloc/free and opt
> instead for active/inactive nodes - I'm not sure whether that might
> be appropriate for these hash entries (haven't gone through pmwebapi
> in detail yet), but further food for thought.

(Later.)

- FChE

<Prev in Thread] Current Thread [Next in Thread>