Hi Ken,
----- Original Message -----
> Nothing like a BSD-based platform to shake out some portability
> issues!
>
Awesome.
>
> pmie/pragmatics.c - pow() (non-)issue
>
> Include open source version of pow() for platforms where this is
> not
> in the maths library ... only needed in this one place if
> configure
> determines we do not HAVE_POW.
The (new) comment in the code says
"We have not found a platform yet that needs this"
which seems contrary to the above (if we don't need it, why...?)
Assuming we really do need it just for this platform, I guess I'd
anticipate it live with the other helper routines that are added
in specifically for a platform, in src/libpcp/src/util.c (dirname,
basename, scandir, and friends) so that when the next pow() call
is added somewhere else in PCP, the build doesn't fail.
Could sanitise that code a little too - the endianness sniffing in
there looks odd & the commented out header seems unneeded too.
> Real versions of sed (from the olden days) do not have a -i
> command line option.
Heh. Looks like "real" kernels prefer /dev/kmem readers too. :)
cheers.
--
Nathan
|