pcp
[Top] [All Lists]

pcp updates - porting to NetBSD

To: pcp@xxxxxxxxxxx
Subject: pcp updates - porting to NetBSD
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri, 22 Feb 2013 07:26:06 +1100
Delivered-to: pcp@xxxxxxxxxxx
Reply-to: kenj@xxxxxxxxxxxxxxxx
Nothing like a BSD-based platform to shake out some portability issues!

Changes committed to git://oss.sgi.com/kenj/pcp.git dev

 configure                            |15630 ++++++++---------------------------
 configure.in                         |   47 
 qa/src/GNUlocaldefs                  |    2 
 qa/src/proc_test.c                   |    6 
 src/include/builddefs.in             |    6 
 src/include/buildrules               |    2 
 src/include/pcp/platform_header.h.in |    7 
 src/libpcp/src/check-statics         |    4 
 src/libpcp/src/config.c              |    6 
 src/libpcp/src/connectlocal.c        |   14 
 src/libpcp/src/derive.c              |   22 
 src/libpcp/src/err.c                 |    2 
 src/libpcp/src/fault.c               |   10 
 src/libpcp/src/pmns.c                |    3 
 src/libpcp/src/spec.c                |    2 
 src/libpcp/src/util.c                |   31 
 src/libpcp_http/src/http_fetcher.c   |    2 
 src/libpcp_pmda/src/queues.c         |    4 
 src/pcp/pcp.sh                       |    8 
 src/pmdas/GNUmakefile                |    2 
 src/pmdas/bash/event.c               |   39 
 src/pmdas/bash/util.c                |    4 
 src/pmdas/gfs2/glocks.c              |    4 
 src/pmdas/gfs2/sbstats.c             |    4 
 src/pmdas/hotproc/src/hotproc.c      |    4 
 src/pmdas/linux/interrupts.c         |   10 
 src/pmdas/linux/linux_table.c        |    4 
 src/pmdas/linux/proc_meminfo.c       |    2 
 src/pmdas/linux/proc_net_dev.c       |    6 
 src/pmdas/linux/proc_partitions.c    |    4 
 src/pmdas/linux/proc_slabinfo.c      |    2 
 src/pmdas/linux/proc_stat.c          |    4 
 src/pmdas/linux/proc_vmstat.c        |    2 
 src/pmdas/linux_proc/cgroups.c       |    8 
 src/pmdas/linux_proc/getinfo.c       |    2 
 src/pmdas/linux_proc/ksym.c          |    2 
 src/pmdas/linux_proc/pmda.c          |    4 
 src/pmdas/linux_proc/proc_pid.c      |   10 
 src/pmdas/linux_proc/proc_runq.c     |    2 
 src/pmdas/logger/event.c             |   23 
 src/pmdas/logger/util.c              |    4 
 src/pmdas/mmv/mmv.c                  |    4 
 src/pmdas/netbsd/GNUmakefile         |   68 
 src/pmdas/netbsd/disk.c              |  216 
 src/pmdas/netbsd/help                |   95 
 src/pmdas/netbsd/netbsd.c            |  979 ++
 src/pmdas/netbsd/netbsd.h            |   44 
 src/pmdas/netbsd/netif.c             |  233 
 src/pmdas/netbsd/root_netbsd         |  172 
 src/pmdas/pmcd/src/pmcd.c            |    2 
 src/pmdas/shping/shping.c            |    2 
 src/pmdas/weblog/check_match.c       |    2 
 src/pmdas/weblog/weblog.c            |    2 
 src/pmdas/windows/helptext.c         |    4 
 src/pmdas/windows/instance.c         |    4 
 src/pmie/src/dstruct.c               |   20 
 src/pmie/src/pragmatics.c            |  323 
 src/pmie/src/stomp.c                 |    2 
 src/pmieconf/rules.c                 |    6 
 src/pmlogger/pmlogger.c              |    2 
 src/pmlogrewrite/util.c              |    4 
 src/pmns/stdpmid.pcp                 |    1 
 src/pmstore/pmstore.c                |    2 
 63 files changed, 6289 insertions(+), 11852 deletions(-)

commit 4e5c39cba0be9be0d058d526b33d23920efe3cf2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:23:41 2013 +1100

    Add a NetBSD platform pmda
    
    Note this is heavily borrowed from the FreeBSD pmda, and provides
    only a handful of metrics as a proof of concept ... considerable
    extra effort would required to make this a useful platform pmda.

commit 46d5cdfde3ff10982de750c9aa9a1841efa766be
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:18:58 2013 +1100

    qa/src/proc_test.c - NetBSD porting
    
    Some code change for procfs and correct isdigit() casting.

commit e1893313554005099fcbc24af5792fefd2562c38
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:17:52 2013 +1100

    weblog pmda - fix compiler warning
    
    Make initialization unconditional to remove compilation warnings
    on NetBSD.

commit 7d1726a372f6cf6d5e54dce21d53ba638a40c425
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:16:40 2013 +1100

    pmie/pragmatics.c - pow() (non-)issue
    
    Include open source version of pow() for platforms where this is not
    in the maths library ... only needed in this one place if configure
    determines we do not HAVE_POW.

commit 863b718681e0520352e11fd74b0c50b89d7b1c21
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:15:44 2013 +1100

    libpcp/util.c - prefer mkstemp() over tempnam()

commit 99cc8e892d72c6692898af3ffdad95e8cd2e6c9f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:14:37 2013 +1100

    libpcp/pmns.c - workaround NetBSD compiler warning

commit 3ef3be998fe4a6ff795f58af6a39f9ea3c850f25
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:12:59 2013 +1100

    NetBSD porting - platform differences
    
    Changes to required to support existing functionality to NetBSD.
    
    Mostly API differences (have posix_memalign() but not memalign(),
    stat() stucture name differences, gcc __thread is broken) and
    command line option variations (fmt -g N not fmt -N), different
    signal semantics.

commit f128d3d16c7edf5bb6127b2018a5a472c5e5fcd4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:11:41 2013 +1100

    builddefs - NetBSD porting
    
    Real versions of sed (from the olden days) do not have a -i
    command line option.

commit ac9c0a56b49e53a0d6872d04ff438a8bab1e17e5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:10:09 2013 +1100

    QA src make usage
    
    Replace make by $(MAKE) for platforms where MAKE=gmake is needed
    because make does not exist.

commit ceb3eb1c8feae3ece9d3bd682a077a9b16e31fe5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:08:43 2013 +1100

    Porting to NetBSD
    
    Platform configuration changes, e.g.
    + __thread is broken in some gcc versions, sigh
    + check for pow() availability and library
    + check for posix_memalign() availability

commit 16ad1976095816ebc03ddc90ba67d5265adb66e9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Feb 22 07:03:19 2013 +1100

    Casting for character classification routines
    
    We were being sloppy and inconsistent about casting the argument
    to the character classificaton routines like isalpha(), isspace(),
    isdigit(), isprint(), toupper(), tolower(), etc.
    
    If the argument is type char, it needs to be cast to (int) to
    be correct for all implementations of these library routines.
    
    Without this we get compilation warnings on NetBSD, for
    example.



<Prev in Thread] Current Thread [Next in Thread>