A bunch of changes here ... mostly pmie tweaking and pmie QA, but also
copyright notice cleanup and logger pmda bug fix.
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
man/man1/pmie.1 | 3
qa/457 | 1
qa/458 | 1
qa/461 | 1
qa/514 | 40 +
qa/514.out | 952 +++++++++++++++++++++++++++++++++++++++++++++-
qa/520 | 111 ++++-
qa/520.out | 612 +++++++++++++++++++++++++++++
qa/521 | 77 +++
qa/521.out | 52 ++
qa/523 | 89 ++++
qa/523.out | 497 ++++++++++++++++++++++++
qa/group | 3
qa/src/GNUlocaldefs | 3
qa/src/mkmultihost | 69 +++
qa/src/multi-vm00.0 |binary
qa/src/multi-vm00.index |binary
qa/src/multi-vm00.meta |binary
qa/src/multi-vm01.0 |binary
qa/src/multi-vm01.index |binary
qa/src/multi-vm01.meta |binary
qa/src/multi-vm02.0 |binary
qa/src/multi-vm02.index |binary
qa/src/multi-vm02.meta |binary
qa/src/multi-vm03.0 |binary
qa/src/multi-vm03.index |binary
qa/src/multi-vm03.meta |binary
qa/src/pthread_barrier.h | 27 +
qa/src/xmktime.c | 21 -
src/pmie/src/GNUmakefile | 15
src/pmie/src/dstruct.h | 1
src/pmie/src/lexicon.c | 2
src/pmie/src/pragmatics.c | 19
src/pmie/src/show.c | 199 +++++++--
34 files changed, 2665 insertions(+), 130 deletions(-)
commit 46d40b88a51a1fd54ffd9adade7a2e35294a4062
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Jan 7 06:39:37 2013 +1100
pmie/show.c - minor rework for aggregate/extrema operators
Fix some corner cases where substitutions for %h, %i and %v were
not correct in the presence of aggregate (sum_*, avg_*, count_*)
or extrema (min_*, max_*) operators.
commit 2f1689d300a5274af975d8258e30bdec8e2ac789
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Jan 6 16:59:55 2013 +1100
qa/523 (new) - more pmie max_*() and min_*() tests
commit 86a0eafdc4ac1ad8552b97c71f353a4108fa93a9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Jan 6 16:53:26 2013 +1100
qa/src/mkmultihost - randomize PMDA states across hosts
Script primes the PMDAs with a random number of fetches, then
creates the archives.
New archives as a result.
commit 7c614925f2bfa6c7efb267f6a27847fcd20e7c2f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Jan 6 16:51:22 2013 +1100
qa/521.out - new output after pmie changes
Bogus count scales Gcount and Tcount have been retired.
commit 3712bfae9301b9e2b9e6f7ec582f71ceebfd188f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Jan 6 16:49:28 2013 +1100
qa/520.out - new output
src/multi-vm0? archives were remade (now smack pmcd a random number of
times to ensure the sample metrics are not the same across all hosts),
and the output (reported values) is slightly different.
commit 82249fd7d2c31dcf17f2791ae46eec8a2994d271
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Jan 6 16:48:00 2013 +1100
qa/520 - tidy up filtering and full reporting
Extra stuff inherited from 514 that is not needed here.
commit 4e34668c8123472ba7cab46c1cb66617f5fc2bc3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jan 4 17:10:26 2013 +1100
qa/520 and qa/521 - more pmie test coverage
520 - multihost cases from an archive, checking -d and %h, %i and %v
bindings
521 - pmie unit scale factors (space, time and count) and predefined macros
commit e329f315ddcdde3f0b2eff7e312983fb1556caa3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jan 4 17:04:26 2013 +1100
qa/514 - complete coverage for pmie rules
Previous commits were interim ... this one is now done.
commit 5b7e534d36876ea8aea08696bb05b7fdbda41075
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jan 4 16:57:21 2013 +1100
pmie - retire impossible count scale factors
The count scale factors (keywords) Gcount (10^9) and Tcount
(10^12) cannot possibly produce the correct results, as their
values (9 and 12 respectively) are stuffed into the scaleCount
field of a pmUnits struct ... but scaleCount is a 4-bit _signed_
int, so the maximum positive value it can take is 7.
Quietly retire Gcount and Tcount from the lexical scanner and the
man page ... oops.
Found while developing QA 521.
commit 8fcab0b0183a4fcf582109dba0233e06effba8ce
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jan 4 14:02:21 2013 +1100
pthread_barrier.h - update licence comment
Use correct open source licence verbage as per today's email from
Brent Priddy (toopriddy@xxxxxxxxx) to Ken McDonell.
commit 444de67901cbab72062eddcaf4f2795a733b8d3b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Jan 4 06:07:06 2013 +1100
qa/xmktime.c - correct copyright notice
commit f6aa4e48a0ada3549ccd5edcb9ccdaa15cdb8379
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Jan 1 08:57:47 2013 +1100
pmie - fix corner case fetch profile handling bug
Found during QA/514 development.
If we have multiple rules, with metrics (or the same metric) over a
common instance domain, and _some_ rules include explicit instance
names (e.g. #foo #'foo-bar') and _some_ rules have no instance
names (implying all instances), then we _may_ botch the handling
of the fetch profile and fetch fewer instances than are required.
The effect depends on the order of the rules in the configuration
file and the non-deterministic order of rule evaluation after
connection to pmcd is made (or re-established). So, this is a
little ellusive!
Fortunately the pre-conditions are probably rarely seen in real
production rule sets.
commit 346e73ecb3a839a49ca2b34509d7895066527c21
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Jan 1 08:56:25 2013 +1100
pmie/show.c - tidy up for -d command
More code cleansing to improve the consistency of reporting formats
and handling of expression trees in "debug" mode.
commit a8617546d6e3af5c79d46ca77f243ecc7fcc4a13
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Dec 31 08:57:12 2012 +1100
qa - time synchronized multi-host archives
Added for use in pmie QA.
commit 2824f94c41285d5b6ac2af0750808be52fa203b8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Dec 25 06:51:44 2012 +1100
qa/logger pmda - avoid first time infinite loop
The pmda's Install script calls _choose_configfile() which will create
$PCP_VAR_DIR/config/logger if it does not exist ... but the first time
one of these QA tests is run the directory does not exist, the cp in
the QA script to set things up fails and the Install script goes into
an infinite loop.
|