pcp
[Top] [All Lists]

Re: Makepkgs fallout

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Subject: Re: Makepkgs fallout
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 28 Nov 2012 17:04:16 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1354134229.1662.22.camel@xxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>

----- Original Message -----
> > ...
> > I think this is a special case of not fully supporting --prefix yet
> > in our
> > development workflow.  If we get a
> > 
> >   % configure --prefix=/developer/tree ; make ; make install
> > 
> > installation working as the main way to do development, and then
> > have the
> > qa testsuite, configured with the same prefix, should be able to
> > run against
> > the --prefix tree.  Then testing the installed system version is
> > just a
> > special case, of --prefix=/usr --FOODIR=/bar etc, as per Makepkgs.
> > 

BTW, we'll need an orthogonal plan for the full-remote testing, where
pcpqa at times ssh's into remote machines and bounces requests to/from
client/server ... I don't think that will be practical with anything
other than a packaged install (cos keeping track of whats installed on
remote machines too becomes important there).

> The following patch snippet is from a modified qa/src/GNUmakefile:
> 
> +ifeq ($(QA_IN_TREE),'')
>  include $(TOPDIR)/src/include/builddefs
> +else
> +include /usr/include/pcp/builddefs
> +endif
> 
> applying the same change to the parent qa/GNUmakefile and then
> invoking
> make as
>       $ QA_IN_TREE=yes make
> in the handful of places we run make from the QA scripts (not the
> build)
> will fix the problem for everyone I believe.
> 
> If we can get consensus on this I'll make the changes.

Could this be replaced with "make -f GNUmakefile.install"?  Perhaps
check could check for a (checked-in) GNUmakefile.install, use that
if found, else continue on with GNUmakefile?  No additional variables
or state would need to be remembered then & both cases get exercised
at the appropriate times.  I think.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>