Changes committed to git://oss.sgi.com/pcp/pcp.git dev
qa/115 | 18 ------------------
qa/115.out | 2 ++
qa/381 | 12 ++++--------
qa/504 | 14 --------------
qa/575 | 18 ++++++++++++------
qa/575.out | 1 +
qa/622 | 12 +++++++++---
qa/common.config | 9 +++++++--
qa/common.filter | 26 ++++++++++++++++++++++++++
src/pmie/rc_pmie | 30 +++++++++++++++++++++---------
src/pmlogger/rc_pmlogger | 26 +++++++++++++++++---------
11 files changed, 99 insertions(+), 69 deletions(-)
commit 26129ab3fc91a77aefa3c2807c2b49dec4631036
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Nov 28 14:30:31 2012 +1100
Fix race conditions in pmie and pmlogger startup scripts
Recent changes to tempfile handling has regressed the pmie and
pmlogger startup scripts. Errors of the form:
/etc/rc.d/init.d/pmlogger: line 100: /var/tmp/pcp.5vfQsSHKo/pmcheck: No
such file or directory
are now produced.
Because sections of these two scripts are run in parallel with
the original script, we are open to race conditions where the
main script exits and removes the temporary directory before the
co-process has an opportunity to create its temporary file. We
can resolve this using separate temporary dirs and trap handling
which thus no longer race.
Worse still, QA failed to detect the problem. At least one test
that should have found the problem trivially (575) failed to, as
a result of aggressively discarding stderr and stdout instead of
using filtering. This has been rectified and common pmie filter
routines abstracted (from tests 115, 504 and 575) to simplify the
task for all current and future tests.
commit 5a973fe036eccbe0683f4445cc8c3ca056d6a9c9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Nov 28 14:14:06 2012 +1100
Test 381 needs to check the remote host has pmdasample
commit dce7241598ab02a672aff35520a7c551fc326a85
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Nov 28 14:13:05 2012 +1100
Remove a couple of accidental QA test/config changes
commit 803a18eebbb8607670801bd597276ca8056d5d86
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Nov 28 09:39:59 2012 +1100
Add my local test domain into the qa mix
|