pcp
[Top] [All Lists]

Re: [pcp] pcp updates: qa + packaging/configuring

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: qa + packaging/configuring
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu, 22 Nov 2012 06:22:13 +1100
Cc: pcp@xxxxxxxxxxx
In-reply-to: <2031511353.29165231.1353470500146.JavaMail.root@xxxxxxxxxx>
References: <2031511353.29165231.1353470500146.JavaMail.root@xxxxxxxxxx>
On Tue, 2012-11-20 at 23:01 -0500, Nathan Scott wrote:
> Changes committed to git://oss.sgi.com/pcp/pcp.git dev
> 
> ...
>
> commit 30912f0277d63c25035d79480ae508e77805bdc7
> Author: Nathan Scott <nathans@xxxxxxxxxx>
> Date:   Wed Nov 21 14:53:10 2012 +1100
> 
>     Use new-world-order tmp dir scheme for deb packages too

Why are we using --with-tmpdir=/var/lib/pcp/tmp in the package builds?

I think the $PCP_TMP_DIR things all belong in /tmp or /var/tmp as per
the historical status quo.  I don't know of any other software that
creates and deletes temporary files below /var/lib

However, there is another BIGGER problem in this area ... the modes of
the temporary directories in the debian packages are wrong (it maybe the
case for other packaging but these are the packages I've been
concentrating my diagnosis on).  They should be drwxrwxrwxt but are
being packaged and installed as drwxr-xr-x.

This is a relatively recent regression, and NOTHING related to pmlogger
(or pmie) works with the directory modes set like this ... they need to
be world writeable and "sticky" (aka "restricted deletion flag" set).

I cannot see where the problem has being introduced as the Makefile
install lines look correct, as in

        $(INSTALL) -m 1777 -d $(PCP_TMP_DIR)/pmlogger
        $(INSTALL) -m 1777 -d $(PCP_TMP_DIR)/pmie
        $(INSTALL) -m 1777 -d $(PCP_TMP_DIR)/mmv
        $(INSTALL) -m 1777 -d $(PCP_TMP_DIR)/pmdabash

and sudo make install does the right thing, so this is something related
to a change to install-sh (that I cannot see) or some Debian packaging
magic (that I do not understand).

Once this is understood/fixed, I can get back to my earlier problem
where the non-root change causes additional problems for pmlogger where
the symlink "primary" is unreadable for anyone other than the "pcp"
user ... but more on that later when I get past the current directory
mode obstacle.

And all I wanted to do 3 days ago was QA some pmie "debug mode"
changes ... sigh.

<Prev in Thread] Current Thread [Next in Thread>