pcp
[Top] [All Lists]

Re: NSS/NSPR include file avoidance

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: NSS/NSPR include file avoidance
From: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed, 07 Nov 2012 13:29:54 -0500
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1898649091.22795070.1352273348007.JavaMail.root@xxxxxxxxxx>
References: <1898649091.22795070.1352273348007.JavaMail.root@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1
On 11/07/2012 02:29 AM, Nathan Scott wrote:
Compile tested only at this stage ... keen to hear your thoughts
on this approach though & any review comments you might have on
this patch.  Thanks!

The goal of the patch and the methods used to achieve it are ok with me. I took a quick look at it and didn't spot anything obviously wrong (beyond what Frank found).

The branch is in a decent state with respect to fixes for running the the qa testsuite with NSS enabled. If you like, I'll apply the patch and shake out any problems.

Dave

<Prev in Thread] Current Thread [Next in Thread>