pcp
[Top] [All Lists]

Re: [pcp] qa/041 root filtering

To: Tomas Dohnalek <tdohnale@xxxxxxxxxx>
Subject: Re: [pcp] qa/041 root filtering
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 2 Oct 2012 18:59:43 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1451334599.1554619.1349199448080.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Hi Tomas,

----- Original Message -----
> Hi,
> while testing I found this issue when running 041 test:
> 
> 041 48s ... - output mismatch (see 041.out.bad)
> 21c21
> < $PCP_RC_DIR/pmcd: Warning: Forcing pmcd to terminate!
> ---
> > /opt/rh/devtoolset-1.1/    root ... /etc/rc.d/init.d/pmcd: Warning:
> > Forcing pmcd to terminate!
> 
> This happens, when PCP_RC_DIR contains `root' string in path.

Thanks Tomas, merged now (although I didn't understand where the
"root" was coming from until I looked a bit more closely at how
DTS sets up its environment (with /opt/rh/devtoolset-1.1/root/).

Also, thanks to this closer look, I found another issue that has
been bugging me for awhile - one of the tests was leaving a file
named _filter_pmcd_log behind, which was clearly in error ... it
turns out to be test 041!  So, I've fixed that at the same time.

This was the old annoying behaviour (trouble was finding *which*
test, after hundreds run, and all looked OK on the surface):

$ ./check -q -l 041
041 47s ...
Passed all 1 tests
$ git status
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       _filter_pmcd_log

So - a double thank you!  Your efforts are much appreciated.  In
other news, I'd like to get a PCP point release out, sometime in
the next week or so to a/ rollup all the QA fixes into something
more official (and update DTS RPMs), and b/ get some small fixes
and features out too.

If you have a backlog of these little QA fixes, please push 'em
through this week if you can (I'll also spend some time locally
testing new DTS bits too, see if I can find any other issues).

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>