pcp
[Top] [All Lists]

[Bug 930] pcpqa - TC#383 absolute paths

To: pcp@xxxxxxxxxxx
Subject: [Bug 930] pcpqa - TC#383 absolute paths
From: bugzilla-daemon@xxxxxxxxxxx
Date: Wed, 26 Sep 2012 18:15:44 -0500
Auto-submitted: auto-generated
In-reply-to: <bug-930-835@xxxxxxxxxxxxxxxx/bugzilla/>
References: <bug-930-835@xxxxxxxxxxxxxxxx/bugzilla/>
http://oss.sgi.com/bugzilla/show_bug.cgi?id=930





--- Comment #4 from Nathan Scott <nathans@xxxxxxxxxx>  2012-09-26 18:15:44 CST 
---
(In reply to comment #3)
> 1) 
> Well... I have done it and it is better then initial state, but it is giving 
> me
> warnings on 383:
> 
> > [Wed Sep 26 06:34:05] parse(14748) Warning: pmdaInit: PMDA parse: Unable to 
> > open help text file 
> > "/opt/rh/devtoolset-1.1/root/var/lib/pcp/pmdas/cisco/help": No such file or 
> > directory
> 
> But that file exits! So it is very strange... Any idea what is wrong?
> 

Ah yes - it is a very misleading error message.  What it is
actually trying to say is "I couldn't open the compiled help
text" which is the help.pag and help.dir files.  These don't
necessarily exist here if the pmdas/cisco/Install script has
not yet been run.  For this test it just uses the Cisco parse
utility, not the installed PMDA, so for you (evidently) these
files have not been generated yet.

I'll fix the parse utility to not spew this warning (not use
help text), and I'll tweak that message to be more appropriate.

> 2)
> But it is not the only case as you say. For example see
> 
> $ grep "statsfile=" src/pmdas/rsyslog/Install
> statsfile=/var/log/pcp/rsyslog/stats
> $ grep "/var" qa/455
> $sudo sh -c "cat $tmp.stats >> /var/log/pcp/rsyslog/stats"
> $sudo sh -c "cat $tmp.stats >> /var/log/pcp/rsyslog/stats"
> 
> and so.

Hmm, yes, that is very dodgey indeed and should be fixed
(done now).

This particular issue may be related to (or even causing)
that hanging test you observed a little while ago btw.

> I will hopefully do some deep review asap and eliminate these cases.

That would be great, thanks!  Feel free to send any patches
directly to the pcp@xxxxxxxxxxx mailing list if you prefer.
A comment at the start of each patch saying what its about
will mean I don't have to make something up on your behalf
too, which may not be as accurate/heart-felt.  :)

cheers.

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

<Prev in Thread] Current Thread [Next in Thread>