Changes committed to git://oss.sgi.com/pcp/pcp.git dev
man/man3/pmierrstr.3 | 25
man/man3/pmiputvaluehandle.3 | 2
man/man3/pmiunits.3 | 33
qa/511 | 42
qa/511.out | 44
qa/707 | 46
qa/707.out | 79 -
qa/708 | 26
qa/708.out | 2
qa/709 | 57
qa/709.out | 80 +
qa/group | 4
qa/sadist/859117-rhel5.bin |binary
qa/sadist/859117-rhel5.xml | 2282 ++++++++++++++++++++++++++++++++++++++++
qa/sadist/GNUmakefile | 6
qa/sadist/f16-sa20.bin |binary
qa/sadist/fche-csb6-rhel6.bin |binary
qa/sadist/rhel5-sa20.bin |binary
qa/sadist/smash-rhel5.xml | 1594 +++++++++++++++++++++++++++
qa/src/GNUlocaldefs | 2
qa/src/test_pcp.py | 24
qa/src/test_pmi.py | 100 +
src/include/pcp/import.h | 24
src/libpcp_import/src/import.c | 32
src/perl/LogImport/Changes | 6
src/perl/LogImport/LogImport.pm | 17
src/perl/LogImport/LogImport.xs | 11
src/pmimport/sar2pcp/sar2pcp | 999 ++++++++---------
src/python/pcp.py | 266 ++++
src/python/pcpi.py | 12
src/python/pmapi.c | 89 -
src/python/setup.py | 11
src/python/test_pcp.py | 408 -------
34 files changed, 5116 insertions(+), 1207 deletions(-)
commit 9ac4c8f2f389cfd831985011b9049aded7c7c13a
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 15:32:24 2012 +1000
Extensions to the pcp python module to allow log importing
Adds definitions for the libpcp_import library interfaces,
and a wrapper python class (pmiLogImport) which does the OO
thing. Same approach used as for the core PMAPI (and the
libpcp_gui library used there), although this one is a very
simple API (e.g. no new structures).
Also adds a pmiErr exception class (ala pmErr) which is used
by the pmiLogImport class to handle error situations. Couple
of minor tweaks to comments here and there, for consistency.
QA test 708 and qa/src/test_pmi.py exercises this new code.
While there, I split test 707 into two - one to exercise the
PMAPI python module, the other to do the collectl checking.
commit 274af1071f92343c67ab8edae2e9a9f260b4cf8e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 15:25:23 2012 +1000
Make use of additions to import library in perl wrapper
Since we have just recently added error codes into the perl
PCP::LogImport module, now is a good time to add in these
other two (which were mainly added for Python, but we may as
well be consistent).
Perl interfaces for pmiID() and pmiInDom() are now available.
commit 3b0baaad491eb229c8c4e3031dc4d5fcc3402fdb
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 15:22:39 2012 +1000
Extend the import API to ease scripting language integration
Add two additional helper routines into libpcp_import to make
life easier for scripts. Similar to the existing pmiUnits()
interface, we now also have pmiID() and pmiInDom() available
for high-level language wrappers.
Since I was extending the API, I took the opportunity to add
in the pmiErrStr_r() interface along the lines of the same in
core PMAPI, for obvious reasons (no future API changes should
be needed for thread-safe-ing if ever that is done).
commit 0362e16ca055e01646afc6a02d929420a4370fed
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 14:13:19 2012 +1000
Update some dated comments in test_pcp.py
commit 0493acfcd6e29d17c2bd52d4fb3157a062702bd8
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 11:11:14 2012 +1000
Rename a sar2pcp test case to better track source platforms
commit e01ce41c14faa3bf4c349a5c99088554a3d2709f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 10:44:59 2012 +1000
Fix a typo on pmiPutValueHandle man page synopsis
commit 0413afd4da0b54f8f27d8ee40b87abe1b9462971
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Sep 23 10:44:35 2012 +1000
Remove no-longer-used py test file, resides below qa/src now
commit 11f0e2a371fb05940209b36423bb4731e2f9ea82
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat Sep 22 21:51:08 2012 +1000
Fix another problem in sar2pcp handling of ancient sar archives
Really old versions of sysstat used commas in place of decimal
points in the XML floating point numbers. This causes failure
whenever perl attempts to convert that string to a float. So,
we need to fix up the number (give it a decimal point instead
of a comma) before doing any arithmetic or attempting to store
the number.
This is the cause (if you should ever observe it) of this type
of perl warning/failure message: (e.g.)
'Argument "\x{31}\x{2c}..." isn't numeric in addition (+)'
Red Hat Bugzilla: 859117
commit bfa70f551f4d403859a081e71ca88b55868756db
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat Sep 22 18:48:37 2012 +1000
Update QA test 511 with more sar data output
commit 98dd8a8e06d31dc7bc7e1e1e6f03acceeb169bf9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat Sep 22 17:02:36 2012 +1000
Fix problem in sar2pcp handling of ancient (sysstat-7) sar archives
Now workaround RHEL5 sar (sysstat v7, current is v10) XML format
differences. Network interface name tags are in different places,
CPU metrics are differently named and some are missing entirely,
file/inode counts are differently named too.
Refactored the mechanism for dealing with tags we know about but
choose to ignore at present - this is now a single hash lookup, in
place of many many conditionals.
Should I be worried that this pmimport vs sar XML cat & mouse game
is actually becoming quite fun?!?
Red Hat Bugzilla: 859117
commit e6bf0e18b962b22cc9157778ce666b04c2210366
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat Sep 22 14:44:53 2012 +1000
Add a bevy of additional sar2pcp test cases (some still fail atm)
commit 0a2913d4934c235431fcd9db52a972c7a91abcca
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat Sep 22 14:36:40 2012 +1000
Fix problem in sar2pcp handling of down-rev (10->9) sar archives
This issue uncovered a bit of a design issue in our sar2pcp tool,
where it assumes that the output from the first sample is a good
representative sample for every other sample. This falls down in
practice, because some tags are dynamic (network interfaces may
appear/disappear on the fly, as one observed example).
To resolve this, I've replaced the use of an indexed array of PMI
handles with a hash that maps metric names (+instance optionally)
to handles. On first observation of any XML tag, the PMI handle
is created (not defined in hash), and all subsequent occurences
will use the cached handle.
Also in this commit is cleanup to use single-quotes for all non-
interpreted strings (most), and an option allowing XML files to
be passed into sar2pcp in place of binary files (heuristic used,
presence of .xml suffix seems a good indicator). Mark requested
this to ease the pain of having to run sar2pcp on the same system
as sadf, which has to be the same system (same sysstat anyway) as
customers are using.
But wait, there's more...
Red Hat Bugzilla: 859117
commit 4d555c7d2224e9bea1a7bc894aac0e50a7e0e854
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sat Sep 22 14:27:34 2012 +1000
Add PMI error codes into the PCP::LogImport perl module
|