On 08/30/2012 06:58 PM, Nathan Scott wrote:
There were no other new QA failures (theres a handful of existing
failures I'm still working my way through). I'm also not setup for
remote tests yet (see below) which is important for this checking -
hence I put it all in a new "nssmerge" branch for now, so we can work
from that starting point, which is almost ready to merge.
I found a couple of problems with the way __pmAccAddClient was being
called from the qa code (was being passed a pointer to 'struct in_addr',
but now expects __pmIPAddr). I have managed to build the branch and get
the tests started. Not done yet, but no failure in 062.
One nit with the test setup: ./common expected that pmcd would already
be running. Not hard to do, but perhaps it should just start it if one
is not running.
I'll send you my results when they're done and push the code to the
nssmerge branch the at that time, if I am able. If not, I can send you a
patch.
Just a reminder that Monday is a holiday here in Canada (and in the U.S.
as well).
Have a great weekend!
Dave
|