Coverity Errors
ID 	Checker 	File 	Function 	Classification

3 	BAD_FREE 	/src2/git/pcp/src/pmdumplog/pmdumplog.c 	dumpresult 	UNINSPECTED

commit 915fb200651a3f3f68abbee3480a4981e310ca39
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Tue Feb 14 16:18:20 2012 +1100

    Minor code clarification for Coverity #3
    
        modified:   src/pmdumplog/pmdumplog.c


21 	CONSTANT_EXPRESSION_RESULT 	/src2/git/pcp/src/pmlogreduce/dometric.c 	dometric 	UNINSPECTED
22 	CONSTANT_EXPRESSION_RESULT 	/src2/git/pcp/src/pmlogreduce/indom.c 	doindom 	UNINSPECTED
23 	CONSTANT_EXPRESSION_RESULT 	/src2/git/pcp/src/pmlogreduce/scan.c 	doscan 	UNINSPECTED
  -- (above 3) already fixed by someone else

34 	DEADCODE 	/src2/git/pcp/src/libpcp_trace/src/trace.c 	_pmauxtraceconnect 	UNINSPECTED
  - harmless, ignored

37 	FORWARD_NULL 	/src2/git/pcp/src/pmlogreduce/dometric.c 	dometric 	UNINSPECTED
  - already fixed

38 	FORWARD_NULL 	/src2/git/pcp/src/pmlc/<stdout> 	yy_get_next_buffer 	UNINSPECTED
  - yacc or lex, ignored

58 	FORWARD_NULL 	/src2/git/pcp/src/pmlc/actions.c 	Status 	UNINSPECTED

commit 1f3d63c62bafda3907b387012c7611a5df7a0703
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Tue Feb 14 16:30:44 2012 +1100

    Fix NULL dereference for IPC version < LOG_PDU_VERSION2, Coverity #58
    
        modified:   src/pmlc/actions.c

61 	FORWARD_NULL 	/src2/git/pcp/src/pmlc/actions.c 	Status 	UNINSPECTED

commit d94748ecc72f68bd3fd5f122d8c631e413c00ba6
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Tue Feb 14 16:37:04 2012 +1100

    No support for logger IPC version < LOG_PDU_VERSION2
    
        modified:   src/pmlc/actions.c

65 	FORWARD_NULL 	/src2/git/pcp/src/pmns/pmnsdel.c 	delpmns 	UNINSPECTED
 -- needs another look TODO

71 	FORWARD_NULL 	/src2/git/pcp/src/pmstat/pmstat.c 	main 	UNINSPECTED
  - OK, ignored

74 	FORWARD_NULL 	/src2/git/pcp/src/pmcpp/pmcpp.c 	directive 	UNINSPECTED

commit 80eddbcbe47fcc024699530029e926664c43f204
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Tue Feb 14 16:59:11 2012 +1100

    Guard against dereferencing a zero length macro value, coverity #74
    
        modified:   src/pmcpp/pmcpp.c


85 	NEGATIVE_RETURNS 	/src2/git/pcp/src/cpan/PMDA/PMDA.c 	XS_PCP__PMDA_put_sock 	UNINSPECTED
  -- TODO

86 	NEGATIVE_RETURNS 	/src2/git/pcp/src/libpcp_mmv/src/mmv_stats.c 	mmv_stats_stop 	UNINSPECTED
  -- need to somehow handle munmap(addr, (size_t)-1)  ... TODO

106 	NEGATIVE_RETURNS 	/src2/git/pcp/src/pmdumplog/pmdumplog.c 	rawdump 	UNINSPECTED
  -- not a problem, ignored

107 	NEGATIVE_RETURNS 	/src2/git/pcp/src/libpcp_gui/src/record.c 	pmRecordSetup 	UNINSPECTED
commit a2a7f04689b1fbd677b088f1e40c93d99dc92522
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Tue Feb 14 15:29:39 2012 +1100

    Check return of mkstemp.
        modified:   src/libpcp_gui/src/record.c

111 	NEGATIVE_RETURNS 	/src2/git/pcp/src/pmlogreduce/logio.c 	_pmLogGet 	UNINSPECTED
  -- ignore

123 	NO_EFFECT 	/src2/git/pcp/src/cpan/MMV/MMV.xs 	list_to_indom 	UNINSPECTED

commit 19915b5592f384dc3ecd009b316fba63fc069b6b
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 12:00:32 2012 +1100

    Fix error handling in return from list_to_instances().
    Coverity #123
    
        modified:   src/cpan/MMV/MMV.xs

126 	NULL_RETURNS 	/src2/git/pcp/src/cpan/PMDA/PMDA.xs 	pmns_write 	UNINSPECTED
  -- already fixed

134 	OVERRUN_DYNAMIC 	/src2/git/pcp/src/libpcp_http/src/http_fetcher.c 	http_parseFilename 	UNINSPECTED
  -- already fixed

135 	OVERRUN_DYNAMIC 	/src2/git/pcp/src/dbpmda/src/pmda.c 	fillResult 	UNINSPECTED
  -- already fixed

136 	OVERRUN_DYNAMIC 	/src2/git/pcp/src/libpcp_http/src/http_fetcher.c 	http_setReferer 	UNINSPECTED
  -- already fixed

137 	OVERRUN_DYNAMIC 	/src2/git/pcp/src/libpcp_http/src/http_fetcher.c 	http_setUserAgent 	UNINSPECTED
  -- already fixed

145 	RESOURCE_LEAK 	/src2/git/pcp/src/libpcp_trace/src/hash.c 	__pmhashinsert 	UNINSPECTED

commit 33720167d138827f40a8b048e80c43aca5dee581
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 12:17:15 2012 +1100

    Fix resource leak on failed malloc.  Coverity #145
    
        modified:   src/libpcp_trace/src/hash.c


151 	RESOURCE_LEAK 	/src2/git/pcp/src/pmevent/pmevent.c 	myeventdump 	UNINSPECTED
152 	RESOURCE_LEAK 	/src2/git/pcp/src/pminfo/pminfo.c 	myeventdump 	UNINSPECTED
  -- TODO, (above two): needs another look - resource leak on err handling path.

171 	RESOURCE_LEAK 	/src2/git/pcp/src/cpan/PMDA/PMDA.xs 	list_to_indom 	UNINSPECTED

commit f729697fd619384a2be32c5ac856b68a1f418279
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 12:30:40 2012 +1100

    Plug resource leak in error handling path.
    
        modified:   src/cpan/PMDA/PMDA.xs

And also :

commit 9cd1702ba67daa61f778cb15afb97001d33211cc
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 14:03:55 2012 +1100

    Fix minor build issue after the last Coverity change.
    
    modified:   src/cpan/PMDA/PMDA.xs



186 	RESOURCE_LEAK 	/src2/git/pcp/src/pmlogreduce/logio.c 	_pmLogGet 	UNINSPECTED

commit 833a41070e56cc2396090ffc2c3de07832931a85
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 12:39:39 2012 +1100

    Plug resource leak in error handling path when log
    record read fails. Coverity #186
    
        modified:   src/pmlogreduce/logio.c


195 	RESOURCE_LEAK 	/src2/git/pcp/src/pmevent/pmevent.c 	getvals 	UNINSPECTED

commit 94c772c71bc13079f1f05cd113909f9d62e593b1
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 12:45:12 2012 +1100

    Plug resource leak in err handling path, coverity #195
    
        modified:   src/pmevent/pmevent.c


202 	RESOURCE_LEAK 	/src2/git/pcp/src/pmns/pmnsmerge.c 	sortargs 	UNINSPECTED

commit 7e2632db0dfe61c37e5c1f31fc70de833ceb5ae5
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 12:49:25 2012 +1100

    Free temp memory used by qsort.
    
        modified:   src/pmns/pmnsmerge.c


206 	RESOURCE_LEAK 	/src2/git/pcp/src/pmlc/actions.c 	LogCtl 	UNINSPECTED
  -- ignore - if this happens, memory leak is the least of our worries


236 	RESOURCE_LEAK 	/src2/git/pcp/src/pminfo/pminfo.c 	report 	UNINSPECTED
237 	RESOURCE_LEAK 	/src2/git/pcp/src/pminfo/pminfo.c 	report 	UNINSPECTED
  - ignore (above two) - leaked memory is freed on exit and we don't iterate

254 	REVERSE_INULL 	/src2/git/pcp/src/newhelp/newhelp.c 	main 	UNINSPECTED

commit 56b77c33a117d323e20138a262f2587a9420c2f9
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 13:00:35 2012 +1100

    Check what bp points to, not bp itself. Coverity #254.
    
        modified:   src/newhelp/newhelp.c


255 	REVERSE_INULL 	/src2/git/pcp/src/libpcp_trace/src/trace.c 	_pmlibdel 	UNINSPECTED

273 	SIZECHECK 	/src2/git/pcp/src/libpcp_http/src/http_fetcher.c 	http_setUserAgent 	UNINSPECTED

274 	SIZECHECK 	/src2/git/pcp/src/libpcp_http/src/http_fetcher.c 	http_setReferer 	UNINSPECTED

275 	SIZECHECK 	/src2/git/pcp/src/libpcp_http/src/http_fetcher.c 	http_parseFilename 	UNINSPECTED

300 	UNINIT 	/src2/git/pcp/src/pmlc/actions.c 	ConnectPMCD 	UNINSPECTED

commit c794f207f36a4a743104babaca29b6653e891fce
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 11:53:06 2012 +1100

    Fix possible uninitialized reference to pdu buffer.
    
    Coverity #300.
    
        modified:   src/pmlc/actions.c


314 	UNUSED_VALUE 	/src2/git/pcp/src/libpcp_trace/src/trace.c 	_pmauxtraceconnect 	UNINSPECTED
315 	UNUSED_VALUE 	/src2/git/pcp/src/libpcp_trace/src/trace.c 	_pmauxtraceconnect 	UNINSPECTED

Above two:
commit 6e35cebc703a9683ec071479af717d849e98d572
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Mon Feb 27 13:06:58 2012 +1100

    use the correct variable for the trace port from the environment,
    Coverity 314 and 315.
    
        modified:   src/libpcp_trace/src/trace.c


323 	USE_AFTER_FREE 	/src2/git/pcp/src/pmdumplog/pmdumplog.c 	dumpDesc 	UNINSPECTED
  -- ignore - I think Coverity is wrong.

336 	USE_AFTER_FREE 	/src2/git/pcp/src/libpcp_import/src/archive.c 	_pmi_put_result 	UNINSPECTED
  -- TODO -- needs a closer look.

344 	USE_AFTER_FREE 	/src2/git/pcp/src/pmevent/pmevent.c 	getvals 	UNINSPECTED
  -- should also be fixed by 94c772c71bc13079f1f05cd113909f9d62e593b1 for Coverity #195

346 	USE_AFTER_FREE 	/src2/git/pcp/src/libpcp_import/src/archive.c 	_pmi_put_result 	UNINSPECTED
  -- TODO - needs another pair of eyes

352 	USE_AFTER_FREE 	/src2/git/pcp/src/pmlogreduce/scan.c 	doscan 	UNINSPECTED
  -- TODO - I think this is OK, but needs another pair of eyes

353 	USE_AFTER_FREE 	/src2/git/pcp/src/pmdumplog/pmdumplog.c 	dumpresult 	UNINSPECTED
  -- OK I think after changes for Coverity #3