Summary is in http://www.users.on.net/~kenj/pcp/coverity-pmie.html
Rather more IGNORED ones here than in the other batches, due to Coverity
analysis being clearly wrong (perhaps Coverity is being confused by
Seppo's coding style?).
One case, #351 would benefit from a review.
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
src/pmie/src/dstruct.c | 2 +-
src/pmie/src/pmie.c | 5 +++--
src/pmie/src/symbol.c | 9 ++++-----
src/pmie/src/syslog.c | 3 +--
4 files changed, 9 insertions(+), 10 deletions(-)
commit ce603bc11a8d4726acc0bc7b44f949ab3399f6e9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Feb 10 09:45:24 2012 +1100
pmie/dstruct.c - uninit
Original Coverity case #297
http://people.redhat.com/mgoodwin/pcp-cov/1/297dstruct.c.html#error
Explicitly initialize local pmUnits struct.
commit 2f1b769cd8a69b473108a755e3c13e4ae6725337
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Feb 10 09:32:13 2012 +1100
pmie/symbol.c - reverse_inull
Original Coverity case #258
http://people.redhat.com/mgoodwin/pcp-cov/1/258symbol.c.html#error
Tighten guard.
commit 008b050c47a21af920958427f98a93a258420207
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Feb 10 07:39:52 2012 +1100
pmie/pmie.c - resource_leak
Original Coverity case #231
http://people.redhat.com/mgoodwin/pcp-cov/1/231pmie.c.html#error
Add free() for Coverity, although this is not really needed because the
next call is exit() in main()!
commit f36f18c572189681b2098fb85628b65eb2c77da2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Feb 10 07:03:28 2012 +1100
pmie/syslog.c - resource_leak
Original Coverity case #143
http://people.redhat.com/mgoodwin/pcp-cov/1/143syslog.c.html#error
sdup() not needed here.
|