pcp
[Top] [All Lists]

Re: [pcp] pcp updates - coverity changes for pmcd and pmlogger

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, Mark Goodwin <mgoodwin@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates - coverity changes for pmcd and pmlogger
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 08 Feb 2012 17:31:22 +1100
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1328314805.9716.11.camel@xxxxxxxxxxxxxxxxxxxxxxx>
References: <1328314805.9716.11.camel@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: ndsco1@xxxxxxxxxxxxxxxxxx
Hi Ken,

On 4 February 2012 11:20, Ken McDonell <kenj@xxxxxxxxxxxxxxxx> wrote:
> No problems with the pmcd ones ... summary is here
> http://www.users.on.net/~kenj/pcp/coverity-pmcd.html
>
> For pmlogger, mostly OK, but I'd appreciate reviews for #219 and #220
> (really the one basic issue) where I think the Coverity analysis is
> wrong.  The summary is here

*nod* - yes, looks like namelist and instlist will not have been
allocated taking the code path that Coverity indicates could leak
there, due to the guard by the have_desc local.

BTW, from Marks "leftovers" list I got through the ones I laid claim
to earlier, and then pmval.  Will tackle dbpmda next I think, which
leaves pmlogextract and pmlogrewrite for some brave soul(s)...  :)

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>