10 CHECKED_RETURN /src2/git/pcp/src/pmdas/roomtemp/mlan/linuxlnk.c msDelay IGNORED 13 CHECKED_RETURN /src2/git/pcp/src/pmdas/trace/app3.c pio_sucker IGNORED 14 CHECKED_RETURN /src2/git/pcp/src/pmdas/trace/app2.c io_sucker IGNORED - (above 3) probably not worth fixing 15 CHECKED_RETURN /src2/git/pcp/src/pmdas/mmv/mmvdump.c main FIXED 18 CHECKED_RETURN /src2/git/pcp/src/pmdas/logger/event.c event_init FIXED - (above 2) check return value for fstat, 6c60b8c277af0249b5bc9e3eede28fef1666b416 19 CHECKED_RETURN /src2/git/pcp/src/pmdas/shping/shping.c refresh IGNORED 20 CHECKED_RETURN /src2/git/pcp/src/pmdas/shping/shping.c refresh IGNORED - (above 2) probably not worth fixing 25 DEADCODE /src2/git/pcp/src/pmdas/linux/pmda.c linux_init FIXED - nathan already fixed this one 59 FORWARD_NULL /src2/git/pcp/src/pmdas/lustrecomm/refresh_file.c refresh_file FIXED - check f_s->datap, 77abd89520af7386535a1f13e2e0b28a168b9b5b 72 FORWARD_NULL /src2/git/pcp/src/pmdas/linux/proc_partitions.c proc_partitions_fetch FIXED - don't think this can happen (?), but added defensive code, 7875064dc72e676ec6fab8aa3a0ce9868133169a 75 FORWARD_NULL /src2/git/pcp/src/pmdas/pmcd/src/pmcd.c pmcd_fetch IGNORED - don't think this can happen (?), ignored. 77 MISSING_BREAK /src2/git/pcp/src/pmdas/sample/src/sample.c sample_store FIXED - added a missing break, c6581fce42234935421440ba189a55e33f076ac4 80 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/weblog/weblog.c refresh FIXED - fixed poorly defined macro in weblog.h and formatting in weblog.c, 1fce615be97a0da2654a7a9d6eea4e9dc81260a1 81 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/cisco/probe.c probe_cisco FIXED - check return of dup() before passing to fdopen(), 141e27547f3e66ff73120f6d89d1639a4d5adc49, e8ab89bfe839a30eb38f0ff2713f52c976bf096a 82 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/cisco/telnet.c grab_cisco FIXED - check return of dup() before passing to fdopen(), bc675af185bfcf684105702d21222121e93aec6e 83 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/weblog/weblog.c refresh FIXED - should be fixed by earlier change to wl_close macro 95 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/logger/event.c event_refresh FIXED - fix inverted logic for closing the log fd, dad59809887c88f99b473e6826b27cdb7983b01c 99 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/weblog/weblog.c checkLogFile IGNORED - should be OK (?) 101 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/logger/event.c event_refresh UNINSPECTED - seems to be a problem - need to look more closely at this one. See #95 above too. 102 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/linux/proc_pid.c fetch_proc_pid_statm FIXED 103 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/linux/proc_pid.c fetch_proc_pid_stat FIXED 104 NEGATIVE_RETURNS /src2/git/pcp/src/pmdas/linux/proc_pid.c fetch_proc_pid_stat FIXED - (above 3) only close valid file descriptors, e55684b74c814268427946d9bff4e8e850b526e5 116 NO_EFFECT /src2/git/pcp/src/pmdas/roomtemp/roomtemp.c roomtemp_fetchCallBack IGNORED 117 NO_EFFECT /src2/git/pcp/src/pmdas/mounts/mounts.c mounts_fetchCallBack IGNORED 118 NO_EFFECT /src2/git/pcp/src/pmdas/lustrecomm/lustrecomm.c lustrecomm_fetchCallBack IGNORED 119 NO_EFFECT /src2/git/pcp/src/pmdas/logger/logger.c valid_pmid IGNORED 120 NO_EFFECT /src2/git/pcp/src/pmdas/lmsensors/lmsensors.c lmsensors_fetchCallBack IGNORED 121 NO_EFFECT /src2/git/pcp/src/pmdas/linux/pmda.c linux_fetch IGNORED 125 NO_EFFECT /src2/git/pcp/src/pmdas/linux/pmda.c linux_fetchCallBack IGNORED - (above 7) - conditionals checking if inst < 0, but inst is unsigned. 139 OVERRUN_DYNAMIC /src2/git/pcp/src/pmdas/pmcd/src/pmcd.c pmcd_store UNINSPECTED - I think this one is OK, but could do with another look 146 RESOURCE_LEAK /src2/git/pcp/src/pmdas/linux/cgroups.c prepare_string FIXED - fix memory leak in error handling path, e9f2255c3b28dad71929e1ecbb076b6822fd661e 148 RESOURCE_LEAK /src2/git/pcp/src/pmdas/trace/src/pmda.c parseAuth FIXED 149 RESOURCE_LEAK /src2/git/pcp/src/pmdas/trace/src/pmda.c parseAuth FIXED - (above 2) fix minor memory leak in err handling path, 6c2709aff6abf2d4856f8d9c74bc6e7a1819cd73 154 RESOURCE_LEAK /src2/git/pcp/src/pmdas/linux/cgroups.c refresh_cgroup_subsys FIXED - pmdaCacheStore() .. store() .. insert_cache() makes it's own strdup of name, so this is a leak, 3160e454f088c848a4e7f7bbfe4a0c1e61343500 160 RESOURCE_LEAK /src2/git/pcp/src/pmdas/linux/proc_net_tcp.c refresh_proc_net_tcp FIXED - fclose file in err handling path, 3171338c339f59c1bb724ee234c3a74555738b81 180 RESOURCE_LEAK /src2/git/pcp/src/pmdas/trace/app2.c io_sucker FIXED 183 RESOURCE_LEAK /src2/git/pcp/src/pmdas/trace/app3.c pio_sucker FIXED - (above 2) - fclose the iosucker stream befoe returning, 95f3c1849f7fe8e1fc41b4413997bd9e4977d9e3 190 RESOURCE_LEAK /src2/git/pcp/src/pmdas/process/process.c process_refresh_pid_checks FIXED - nathan already fixed this, a57c46a7b483fbd5ea43234fa8e13226d2e08841 191 RESOURCE_LEAK /src2/git/pcp/src/pmdas/sample/src/sample.c redo_dynamic FIXED - fclose fspec in err handling paths to avoid memory leak, d4ea1c98fbeb39e9fa8849a619b014671cc6dabb 224 RESOURCE_LEAK /src2/git/pcp/src/pmdas/sendmail/sendmail.c do_sendmail_cf FIXED - fclose the file pointer in do_sendmail_cf() to avoid memory leak, 37f3e00f225985c54d954d2d1331e86652c360bc 226 RESOURCE_LEAK /src2/git/pcp/src/pmdas/linux/proc_slabinfo.c refresh_proc_slabinfo FIXED - correctly close file pointer in err handling paths to plug memory leak, f9db46f0edc667414e838c54cf3daf2061b92576 227 RESOURCE_LEAK /src2/git/pcp/src/pmdas/linux/ksym.c read_ksyms FIXED 238 RESOURCE_LEAK /src2/git/pcp/src/pmdas/linux/ksym.c read_sysmap FIXED - (above 2) fclose file pointer in err handling path to avoid mem leak, 60160b0256b119e80226a8fb8db1a42f7d462794 251 RETURN_LOCAL /src2/git/pcp/src/pmdas/trace/src/trace.c readData FIXED - Fixed ptr references to an out of scope variable, 538df34b5cf9e3ef927ac91056c3046aa9e2ec88 259 REVERSE_INULL /src2/git/pcp/src/pmdas/trace/src/trace.c summarydel IGNORED - OK, unless the (void *) argument is NULL. 267 SIZECHECK /src2/git/pcp/src/pmdas/weblog/weblog.c web_fetch IGNORED 268 SIZECHECK /src2/git/pcp/src/pmdas/trace/src/trace.c traceFetch IGNORED 269 SIZECHECK /src2/git/pcp/src/pmdas/shping/shping.c shping_fetch IGNORED - (above 3) probably OK, pmResult packing. 270 SIZECHECK /src2/git/pcp/src/pmdas/sample/src/sample.c sample_fetch IGNORED 271 SIZECHECK /src2/git/pcp/src/pmdas/sample/src/sample.c init_tables IGNORED 272 SIZECHECK /src2/git/pcp/src/pmdas/sample/src/sample.c init_tables IGNORED - (above 3) strictly incorrect, but likely to be benign. 304 UNINIT /src2/git/pcp/src/pmdas/weblog/check_match.c main IGNORED - probably OK - newline_anchor doesn't seem to be used in the regex 309 UNUSED_VALUE /src2/git/pcp/src/pmdas/linux/proc_pid.c fetch_proc_pid_fd FIXED - trivia, 5bad75a77ccdc1ade91f450100ef90cff8c1d110 310 UNUSED_VALUE /src2/git/pcp/src/pmdas/linux/swapdev.c refresh_swapdev IGNORED 311 UNUSED_VALUE /src2/git/pcp/src/pmdas/linux/proc_net_snmp.c get_fields IGNORED 312 UNUSED_VALUE /src2/git/pcp/src/pmdas/linux/proc_net_rpc.c refresh_proc_net_rpc IGNORED 313 UNUSED_VALUE /src2/git/pcp/src/pmdas/linux/proc_net_rpc.c refresh_proc_net_rpc IGNORED - these are unused results from strtok, ignored. Should probably be using strtok_r() instead. 321 USE_AFTER_FREE /src2/git/pcp/src/pmdas/summary/mainloop.c summaryMainLoop IGNORED 333 USE_AFTER_FREE /src2/git/pcp/src/pmdas/summary/mainloop.c summaryMainLoop IGNORED 335 USE_AFTER_FREE /src2/git/pcp/src/pmdas/summary/mainloop.c summaryMainLoop IGNORED - (above 3) seems OK (?) 338 USE_AFTER_FREE /src2/git/pcp/src/pmdas/linux/cgroups.c refresh_cgroup_groups IGNORED 339 USE_AFTER_FREE /src2/git/pcp/src/pmdas/linux/cgroups.c refresh_cgroup_groups IGNORED - (above 2) seems OK, a bit puzzled why Coverity thinks this is wrong.