pcp
[Top] [All Lists]

Re: [pcp] [pcp-announce] pcp-3.5.5 released

To: jeffpc@xxxxxxxxxxxxxx
Subject: Re: [pcp] [pcp-announce] pcp-3.5.5 released
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri, 08 Jul 2011 07:52:00 +1000
Cc: Nathan Scott <nathans@xxxxxxxxxx>, pcp <pcp@xxxxxxxxxxx>
In-reply-to: <20110707144158.GG18916@xxxxxxxxxxxxxx>
References: <780625946.134421.1309986808467.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> <795680652.135149.1310003251207.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> <20110707144158.GG18916@xxxxxxxxxxxxxx>
On Thu, 2011-07-07 at 10:41 -0400, jeffpc@xxxxxxxxxxxxxx wrote:
> On Thu, Jul 07, 2011 at 11:47:31AM +1000, Nathan Scott wrote:
> > Hi all,
> > 
> > The pcp-3.5.5 has been tagged and uploaded.  This is mainly a bug
> > fix release...
> > 
> > pcp-3.5.5 (6 July 2011)
> ...
> >     - Perl changes for Solaris.
> >     - Solaris pmda zpool_vdev_name() api change.
> 
> FWIW, I get a build failure on OpenIndiana:
> 
> === pmie ===
> sed -e's;/var/adm/pmielog/;PCP_LOG_DIR/pmie/;' -e 
> 's;/var/pcp;'/var/lib/pcp';g' control > control.install
> sed -e's;/var/adm/pmielog/;PCP_LOG_DIR/pmie/;' -e 
> 's;/var/pcp;'/var/lib/pcp';g' config.default > config.default.install
> sed -e's;/usr/pcp/bin;'/usr/share/pcp/bin';g' crontab > crontab.install
> === src ===
> /usr/bin/gcc -m64 -fPIC -fno-strict-aliasing  -Wall -g -DPCP_DEBUG 
> -DPCP_VERSION=\"3.5.5\" -DASYNC_API -I../../../src/include   -c -o pmie.o 
> pmie.c
> /usr/bin/gcc -m64 -fPIC -fno-strict-aliasing  -Wall -g -DPCP_DEBUG 
> -DPCP_VERSION=\"3.5.5\" -DASYNC_API -I../../../src/include   -c -o symbol.o 
> symbol.c
> /usr/bin/gcc -m64 -fPIC -fno-strict-aliasing  -Wall -g -DPCP_DEBUG 
> -DPCP_VERSION=\"3.5.5\" -DASYNC_API -I../../../src/include   -c -o dstruct.o 
> dstruct.c
> yacc -d -b `basename grammar.y .y` grammar.y && cp `basename grammar.h 
> .h`.tab.h grammar.h
> "grammar.y", line 61: fatal: invalid escape, or illegal reserved word: expect
> gmake[4]: *** [grammar.h] Error 1

I have no clue about the %expect 184 line in grammar.y ... it was
apparently added in commit f85e09f684d1ec9f8e2ce09b43fdf619865092a9 by
Nathan in Mar 2008 ???

> If I remove the expect line, things seem to build just fine for a while and
> then I hit the same issue in pmlogger/gram.y. ...

%expect 1 this time, but it comes from the same commit as above.

>
> Removing that line makes the
> build continue until it gets into the solaris pmda:
> 


> /usr/bin/gcc -m64 -fPIC -fno-strict-aliasing  -Wall -g -DPCP_DEBUG 
> -DPCP_VERSION=\"3.5.5\" -DASYNC_API -I../../../src/include   -c -o zpool.o 
> zpool.c
> zpool.c: In function `zp_cache_pool':
> zpool.c:78: error: `ZPOOL_CONFIG_STATS' undeclared (first use in this 
> function)
> zpool.c:78: error: (Each undeclared identifier is reported only once
> zpool.c:78: error: for each function it appears in.)
> gmake[3]: *** [zpool.o] Error 1
> 
> Jeff.

The libzfs api seems to be all over the place ... Max and I are chasing
another issue where the API seems to have quietly changed in some
versions of openSolaris.

Jeff, if you could send me your version of <libzfs.h> we may be able to
reverse engineer what has happened.


<Prev in Thread] Current Thread [Next in Thread>