Changes committed to git://oss.sgi.com/pcp/pcp.git dev
src/pmprobe/pmprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 0add9728ca63e1b0180fd4afbd03cdb59c27817c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Jun 29 14:00:32 2011 +1000
Fix potential sigsegv in pmprobe fetching multiple live values.
Having observed this intermittently in our production environment
for some time, finally managed to capture enough state to nut it
out. In live mode the fetch_sts variable was being reset to zero
on every iteration through the loop, which means any initial fail
state is lost for metrics after the first. pmprobe will thus die
during the second iteration, line 415, as invalid result pointer
is dereferenced (took wrong code path to get there).
In the end, easily fixed by not clobbering the fetch status once
inside the loop.
|