pcp
[Top] [All Lists]

Re: [pcp] [RFC/PATCH] pmlogreduce frees invalid pointer

To: Arthur Kepner <akepner@xxxxxxx>
Subject: Re: [pcp] [RFC/PATCH] pmlogreduce frees invalid pointer
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 19 May 2011 20:27:34 +1000 (EST)
Cc: jlim@xxxxxxx, pcp@xxxxxxxxxxx
In-reply-to: <20110519010808.GW8325@xxxxxxx>
Hi Arthur,

----- Original Message -----
> SGI has an ancient bug about pmlogreduce crashing on certain
> (possibly corrupted) archives. The signature of this is:
> ...
> Jonathan made a patch which addresses the memory leak, and also a
> problem where an incorrect index to the metriclist[] could be used
> in rewrite_free(). (I tweaked the patch a bit, but it's basically
> his.)
> 
> Anyway, this seems to fix the problem in the one reproducible test
> case that's available to me. Look OK?
> 

Could you make that test case available?  (or better still, add a little
pcpqa script to exercise the code - see QA tests 266,402,.. for example)

thanks!

-- 
Nathan

<Prev in Thread] Current Thread [Next in Thread>