Changes committed to git://oss.sgi.com/nathans/pcp.git
src/libpcp/src/derive.c | 5 +++--
src/libpcp/src/derive_fetch.c | 5 +++--
src/libpcp/src/events.c | 5 +++--
src/libpcp/src/logmeta.c | 4 ++--
src/libpcp/src/logutil.c | 5 +++--
src/libpcp/src/pdu.c | 8 ++++----
src/libpcp/src/units.c | 5 +++--
src/libpcp/src/util.c | 9 +++++----
8 files changed, 26 insertions(+), 20 deletions(-)
commit 7f83fee764c68732a6ca5b1474b49228f77670c8
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Mar 2 13:28:06 2011 +1100
Use inttypes.h macros in libpcp to address Win32 build warnings.
Moving toward a warning free build on Windows, the main remaining issue
is the following class of problem:
events.c: In function '__pmDumpEventRecords':
events.c:120: warning: unknown conversion type character 'l' in format
events.c:120: warning: too many arguments for format
events.c:124: warning: unknown conversion type character 'l' in format
events.c:124: warning: too many arguments for format
googling suggests this is because the Windows printf implementation is
not conforming to the same standards as most others players (%llu and
%lld are the typical sources of the above warning). Evidentally, all
platforms do have inttypes.h which seems to be recommended for solving
this, Wikipedia states "ISO C99 includes the inttypes.h header file that
includes a number of macros for use in platform-independent printf coding"
in http://en.wikipedia.org/wiki/Printf#Format_placeholders ... this does
indeed address the problem.
commit b0d7f1a42cabaf83feb8fc470847dbfd694f8305
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Mar 2 13:22:55 2011 +1100
When cleanup goes bad - thank goodness for QA. :|
And Ken too, thanks! Reinstate accidentally dropped
return code on read() calls after refactoring.
|