pcp
[Top] [All Lists]

Re: [pcp] pcp updates

To: kenj@xxxxxxxxxxxxxxxx
Subject: Re: [pcp] pcp updates
From: nathans@xxxxxxxxxx
Date: Fri, 10 Dec 2010 20:21:24 +1100 (EST)
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1156011191.270141291972849054.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx>
Sender: nscott@xxxxxxxxxx
----- "Nathan Scott" <nathans@xxxxxxxxxx> wrote:

> > Do you want me to commit?  Probably better to keep this in my tree so
> > there are less problems when we merge back to the mainline tree, so
> > I'll do the commit unless you have another plan.
> 
> Yep, was expecting you'd just commit it - thanks!  I have another
> followup patch (small, just experimenting a bit), but its not ready yet. 
> Will send that later (maybe tomorrow if I get it done).

Here ya go.  This patch adds those other event flags that I think both
clients/agents will need to grok.  There's some cleanup in pmdasample (I
found I was getting confused following all the global state in there, so
reduced it a little to try make it a bit easier to follow, and it spells
out which add_record() parameter is flags, which is nparams - more clear
to my eye, anyway - renames couple of functions for clarity) and also a
bit of refactoring in pminfo.c to extract out the eventdump code, and to
add in decoding/reporting of the additional flags.

cheers.

-- 
Nathan

Attachment: event-flags.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>