On Thu, 2010-12-09 at 09:44 +1100, nathans@xxxxxxxxxx wrote:
> ----- "Ken McDonell" <kenj@xxxxxxxxxxxxxxxx> wrote:
>
> > Changes committed to git://oss.sgi.com/kenj/pcp.git dev
>
> Attached patch gets me to a warning-free build. The last patch
> snippet looks like a legitimate bug - checking name instead of
> names after allocation.
>
> cheers.
Nathan, what's your toolchain and $CFLAGS for the builds ... I don't see
any warnings and I'm using
$ gcc -v
Using built-in specs.
Target: i686-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro
4.4.4-14ubuntu5' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-4.4 --enable-shared --enable-multiarch
--enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix
--with-gxx-include-dir=/usr/include/c++/4.4 --libdir=/usr/lib
--enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-objc-gc --enable-targets=all
--disable-werror --with-arch-32=i686 --with-tune=generic
--enable-checking=release --build=i686-linux-gnu --host=i686-linux-gnu
--target=i686-linux-gnu
Thread model: posix
gcc version 4.4.5 (Ubuntu/Linaro 4.4.4-14ubuntu5)
and from Logs/pcp after Makepkgs
gcc -fpic -fno-strict-aliasing -D_GNU_SOURCE -Wall -g -DPCP_DEBUG
-DPCP_VERSION=\"3.4.1\" -I./src/include -fpic -fno-strict-aliasing
-D_GNU_SOURCE -Wall -g -DPCP_DEBUG -DPCP_VERSION=\"3.4.1\"
-I../src/include -fpic -fno-strict-aliasing -D_GNU_SOURCE -Wall -g
-DPCP_DEBUG -DPCP_VERSION=\"3.4.1\" -I../../src/include -fpic
-fno-strict-aliasing -D_GNU_SOURCE -Wall -g -DPCP_DEBUG -DPCP_VERSION=
\"3.4.1\" -I../../../src/include -fpic -fno-strict-aliasing
-D_GNU_SOURCE -DDYNAMIC_SPEC=\"/var/lib/pcp/pmdas/sample/dynamic.indom\"
-Wall -g -DPCP_DEBUG -DPCP_VERSION=\"3.4.1\" -I../../../../src/include
-c -o events.o events.c
I seem to be getting repeated CFLAGS expansions (!), but not suppressing
any warnings.
Anyway, back to your patch ...
src/pmdas/sample/src/events.c
compiler being picky, change is ok
src/pmdumplog/pmdumplog.c
in reality not a problem, but change is ok
src/pminfo/pminfo.c
my botch, thanks
src/pmlogger/events.c
my botch also, thanks
Do you want me to commit? Probably better to keep this in my tree so
there are less problems when we merge back to the mainline tree, so I'll
do the commit unless you have another plan.
|