pcp
[Top] [All Lists]

Re: [pcp] pmcd on mac rsize ~1.8GB

To: Nathan Scott <nathans@xxxxxxxxxx>, pcp@xxxxxxxxxxx
Subject: Re: [pcp] pmcd on mac rsize ~1.8GB
From: Max Matveev <makc@xxxxxxxxx>
Date: Tue, 16 Nov 2010 19:11:40 +1100
In-reply-to: <19680.48856.366618.859897@xxxxxxxxxxxx>
References: <19680.46333.631517.569650@xxxxxxxxxxxx> <1008460397.46571289795844823.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> <19680.48856.366618.859897@xxxxxxxxxxxx>
Valgrind found the source of the elusive leak - it so happens that on
Darwin scandir(3) does not free the memory it allocated for the array
even if it reports no entires to the caller.

There are two more commits on the leaks branch and these changes keep
pmcd quiet on my two test boxes.

Nathan, let me know if you want me to push this into main tree.

The following changes since commit 30f6900aef2d1a437ece48427c904fefc1f6f143:

  Make lsb-release the last port of call for distro
  information. (2010-10-29 10:24:37 +1100)

are available in the git repository at:
  git://oss.sgi.com/makc/pcp leaks

Max Matveev (4):
      Don't copy strings in PMCD pmda
      Replace use of ctime_r with ctime+strcpy
      Plug a memory drip when looking for pmloggers
      Add explanation about expected behaviour of pmdaFetchCallback

 man/man3/pmdafetch.3        |   29 +++++++++++++++++++++++++----
 src/libpcp/src/logportmap.c |   12 ++++++++++--
 src/pmdas/pmcd/src/pmcd.c   |   29 +++++++++++------------------
 3 files changed, 46 insertions(+), 24 deletions(-)


max

<Prev in Thread] Current Thread [Next in Thread>