pcp
[Top] [All Lists]

Linux pmda patch

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: Linux pmda patch
From: Greg Banks <gnb@xxxxxxxxxxx>
Date: Tue, 31 Aug 2010 12:55:15 +1000
User-agent: Thunderbird 2.0.0.23 (X11/20090817)
G'day,

I found this while cleaning up my trees.

--
Greg.

diff --git a/src/pmdas/linux/pmda.c b/src/pmdas/linux/pmda.c
index 28b8a9c..77d55c0 100644
--- a/src/pmdas/linux/pmda.c
+++ b/src/pmdas/linux/pmda.c
@@ -2335,6 +2335,16 @@ static pmdaMetric metrictab[] = {
     PMDA_PMUNITS(0,0,1,0,0,PM_COUNT_ONE) } },
 
 /* network.ip.reasmtimeout */
+       /*
+        * Note: the semantics and units declared here describe what
+        * the Linux kernel reports through /proc/net/snmp.  The kernel
+        * gets it wrong: RFC1213 defines ipReasmTimeout as the actual
+        * timeout value in seconds rather than a count of timeout events.
+        * We export what the kernel provides because a) we have it
+        * and b) it's actually more useful like that.  Just letting
+        * you know in case you get confused when moving to a system
+        * that gets it right, like Solaris - gnb.
+        */
   { &proc_net_snmp.ip[_PM_SNMP_IP_REASMTIMEOUT], 
     { PMDA_PMID(CLUSTER_NET_SNMP,12), PM_TYPE_U32, PM_INDOM_NULL, 
PM_SEM_COUNTER,
     PMDA_PMUNITS(0,0,1,0,0,PM_COUNT_ONE) } },
<Prev in Thread] Current Thread [Next in Thread>