pcp
[Top] [All Lists]

Re: [pcp] Building PCP on Solaris 10

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] Building PCP on Solaris 10
From: Max Matveev <makc@xxxxxxxxx>
Date: Mon, 23 Aug 2010 11:27:21 +1000
Cc: pcp@xxxxxxxxxxx
In-reply-to: <880513433.204491282283179960.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <19563.41829.490125.839603@xxxxxxxxxxxx> <880513433.204491282283179960.JavaMail.root@xxxxxxxxxxxxxxxxxx>
On Fri, 20 Aug 2010 15:46:20 +1000 (EST), Nathan Scott wrote:

 >> src/pmdas/solaris/netmib2.c    |    6 ++++++

 nathans> This has a wierd commented out #define added in the #includes ... was
 nathans> that intentional?

Obviously not - it was left behind after my earlier attempt to get
access to 64 bit counters for UDP packets on Solaris 10. Alas, it
wasn't as simple as adding extra define so I commented it out but
forgot to remove it.

Which gives me an excuse to do so housekeeping in Solaris PMDA and
remove unused varaibles: I've pushed another commit into dev

commit 72f92a905648ece30c059572219f4caf678d8c2e
Author: Max Matveev <makc@xxxxxxxxx>
Date:   Mon Aug 23 11:15:27 2010 +1000

    Cleanup warnings when compiling Solaris PMDA
    
    Because SunStudio compiler does not warn about unused variables
    some crud has accumulated in the dusty corners.

 src/pmdas/solaris/data.c          |    3 +--
 src/pmdas/solaris/disk.c          |   11 ++++++-----
 src/pmdas/solaris/netlink.c       |    2 --
 src/pmdas/solaris/netmib2.c       |    1 -
 src/pmdas/solaris/solaris.c       |    1 -
 src/pmdas/solaris/sysinfo.c       |    4 ++--
 src/pmdas/solaris/zfs.c           |    5 +++--
 src/pmdas/solaris/zpool_perdisk.c |    1 -
 8 files changed, 12 insertions(+), 16 deletions(-)

max

<Prev in Thread] Current Thread [Next in Thread>