On 07/23/2010 12:06 PM, Nathan Scott wrote:
----- "Mark Goodwin"<goodwinos@xxxxxxxxx> wrote:
On 07/22/2010 05:07 PM, Ken McDonell wrote:
All the core work is done here now.
Thanks Ken!
... The sar2pcp
script could be packaged in perl-PCP-LogImport too (as a
That parts probably not going to fly, cos...
proper utility, not as a demo). Not sure about the dependency
between sar2pcp and the sysstat package (run-time checks
may suffice here?).
rpm will automatically add dependencies on packages by inspection
of the perl sources. And perl-PCP-LogImport should probably not
depend on systat, an XML library, or anything else that it doesn't
actually use.
Not sure about the XML libraries, etc, but the systat dependency
in sar2pcp is limited to running sadf as follows :
my $pid = open(PIPEIN, '-|', "sadf -x $ARGV[0] -- -A");
if (!defined($pid)) {
print "sar2pcp: Failed to launch sadf to convert \"$ARGV[0]\" to XML\n";
exit(1);
}
So that's a reasonably robust run-time check and I'd be surprised if
rpm could auto-figure-out the dependency on sysstat.
I think we are going to have to end up with individual packages for
each importer.
seems like over-kill to me, but if that's how we need to go then I
guess I'm ok with it. What kind of package name did you have in mind?
Something like pcp-sar2pcp, which would depend on sysstat and
perl-PCP-LogImport? Or maybe if sar2pcp was in a sub-package of
perl-PCP-LogImport, it would rightfully be called something like
perl-PCP-LogImport-sar2pcp, which is getting a bit verbose :)
Cheers
-- Mark
|