pcp
[Top] [All Lists]

Re: [pcp] Untracked leftovers in pcp

To: Scott Emery <emery@xxxxxxx>
Subject: Re: [pcp] Untracked leftovers in pcp
From: Greg Banks <gnb@xxxxxxxxxxx>
Date: Wed, 16 Jun 2010 13:24:08 +1000
Cc: "pcp@xxxxxxxxxxx" <pcp@xxxxxxxxxxx>
In-reply-to: <201006160313.o5G3D8NA39947994@xxxxxxxxxxxxxxxxxxxxx>
References: <201006160313.o5G3D8NA39947994@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (X11/20090817)
Scott Emery wrote:
        I do a Makepkgs -clean, but I'm left with... leftovers... according
to git status.
They all look like tmp files from the man page making process

#       src/pmdas/bonding/pmdabonding.1.tmp
#       src/pmdas/dbping/dbprobe.1.tmp
#       src/pmdas/dbping/pmdadbping.1.tmp
#       src/pmdas/kvm/pmdakvm.1.tmp
#       src/pmdas/memcache/pmdamemcache.1.tmp
#       src/pmdas/mysql/pmdamysql.1.tmp
#       src/pmdas/named/pmdanamed.1.tmp
#       src/pmdas/netfilter/pmdanetfilter.1.tmp
#       src/pmdas/news/pmdanews.1.tmp
#       src/pmdas/pdns/pmdapdns.1.tmp
#       src/pmdas/postfix/pmdapostfix.1.tmp
#       src/pmdas/samba/pmdasamba.1.tmp
#       src/pmdas/systemtap/pmdasystemtap.1.tmp
#       src/pmdas/vmware/pmdavmware.1.tmp
#       src/pmdas/zimbra/pmdazimbra.1.tmp
no changes added to commit (use "git add" and/or "git commit -a")

I think this will fix it...
semery@pfe2:~/devel/pcp/src/include> diff -u tmp builddefs.in
--- tmp 2010-06-15 19:48:57.196762269 -0700
+++ builddefs.in        2010-05-26 13:50:18.002513882 -0700
@@ -147,7 +147,7 @@
 LDLIBS = $(LLDLIBS) $(PLDLIBS)
 MAKEOPTS = --no-print-directory
 DIRT = $(LDIRT) dep dep.bak $(OBJECTS) $(CMDTARGET) $(LIBTARGET) \
-       $(STATICLIBTARGET) *.[1-9].gz *.[1-9].tmp
+       $(STATICLIBTARGET) *.[1-9].gz
 DIRDIRT = $(LDIRDIRT)
OBJECTS = $(ASFILES:.s=.o) \


Interestingly  find . -name \*.[1-9].tmp -print finds a bunch of .tmp
files in the ./man/man[1-9]/ area.   They aren't in a pristine checkout
of git, so maybe they are being ignored. Nothing in .git/info/excludes...
or .gitignore... or man/man*/.gitignore.   I failz the gitz... sigh.

When I added the .tmp files a few weeks ago, I added an entry to the top level .gitignore:

diff --git a/.gitignore b/.gitignore
index 1581608..1ac435c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,3 +19,4 @@ libs_files
libs_files.rpm
gram*.tab.c
perl-pcp-*.list
+*.[1-9].tmp

That somehow seems to have been moved to be man/.gitignore after my patch was submitted and before it became commit 10e26829ca631fcd1a03f644ebad1d9e55fb2e9d.
Testing my mod...
./Makepkgs -clean leaves no *[1-9].tmp files behind
semery@pfe2:~/devel/fork/pcp> find . -name *[1-9].tmp -print
<returns nothing>

one make distclean later:
semery@pfe2:~/devel/fork/pcp> git status
# On branch master
# Changed but not updated:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       modified:   src/include/builddefs.in
#


It works. (I didn't commit the mod to builddefs.in)

Well, let me know if removing the .tmp files is bad somehow...

Not at all.  Flush 'em all.  Or fix the .gitignores.

--
Greg.

<Prev in Thread] Current Thread [Next in Thread>