On Fri, 11 Jun 2010 08:55:37 -0500, Martin Hicks wrote:
mort> On Fri, Jun 11, 2010 at 11:44:14AM +1000, Max Matveev wrote:
>> On Fri, 11 Jun 2010 06:39:28 +1000, Ken McDonell wrote:
>>
kenj> The include path for pmiestats.h is wrong
>> The unadorned path to pmiestats.h does not work for me neither on
>> Solaris nor on Linux - I'm expecting to find pmiestats.h in pmie's
>> directory in the tree and not rely on pmiestats.h in
>> /usr/include/pcp whence the path and the extra -I to get to the top of
>> tree when building pmiestatus.
>>
mort> I just moved this include file recently. I needed it for pmieconf, and
mort> it was being installed as part of the install target. This made me
mort> think that putting it into src/include was the right thing to do.
That could explain the differences in the path - Ken's tree has
pmieconf and so includes your change, I was basing my stuff on dev
branch in the main pcp tree which does not have pmieconf yet.
I'm not sure what's the plan is for merging all that together but it
makes sense to take Ken's tree if pmieconf is going to be in the next
release.
max
|