Max,
The include path for pmiestats.h is wrong and there is one compilation
warning on ia32 Linux.
The attached patch addresses both issues.
In a back-handed way, this is another reason to rewrite pmcd and the
pmcd pmda to use shared memory to communicate rather than linking the
pmda directly into the address space of pmcd. If we'd done this, then
pmiestatus would not be needed because pmprobe -v -L pmcd.pmie | sed
would do the same thing. Sigh.
On Thu, 2010-06-10 at 17:59 +1000, Max Matveev wrote:
> Nathan,
>
> I've got a few more changes to consider for the pending release:
> one is to fix a problem with pmie_check/pmie_daily reported by Greg,
> the other is to tweak pmcd integration into Solaris SMF.
>
> Hope it's not too late.
>
> As usual the changes is on top of the current dev branch.
>
> The following changes since commit
> 2b56cad972de53a20833f666b48bc1598d290293:
> Martin Hicks (1):
> Merge remote branch 'mort/pernode-cpu-metrics' into mort-dev
>
> are available in the git repository at:
>
> git://oss.sgi.com/makc/pcp pmie
>
> Max Matveev (2):
> Add utility to extract data from pmie stats files
> Stop Solaris' Service Management Framework from restarting pmcd
> if pmda dies
>
> build/sun/pcp.xml | 3 ++
> man/man1/GNUmakefile | 3 +-
> man/man1/pmiestatus.1 | 53 +++++++++++++++++++++++++++++++++
> src/GNUmakefile | 2 +-
> src/pmie/pmie_check.sh | 3 +-
> src/pmie/pmie_daily.sh | 2 +-
> src/pmiestatus/.gitignore | 1 +
> src/pmiestatus/GNUmakefile | 37 +++++++++++++++++++++++
> src/pmiestatus/pmiestatus.c | 69
> +++++++++++++++++++++++++++++++++++++++++++
> 9 files changed, 168 insertions(+), 5 deletions(-)
> create mode 100644 man/man1/pmiestatus.1
> create mode 100644 src/pmiestatus/.gitignore
> create mode 100644 src/pmiestatus/GNUmakefile
> create mode 100644 src/pmiestatus/pmiestatus.c
>
> _______________________________________________
> pcp mailing list
> pcp@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/pcp
patch.pcp
Description: Text Data
|