On Tue, 08 Jun 2010 18:41:41 +1000, Ken McDonell wrote:
kenj> Max,
kenj> I've reviewed the changes (except the solaris pmda ones) and they look
kenj> ok.
Thanks.
gnb was the first to see that change, he made a few suggestions which
I've added before pushing it for everyone to see but it's nice to have
a confirmation from others.
kenj> With these changes, builds fine on ia32 Ubuntu and the installed images
kenj> pass QA sanity (a new "group" coming to a QA tree near you soon).
Speaking of QA - I've tried to run it on Solaris and run into a few
problems right way, mostly to do with assuming that make is going to
be GNU make and echo will work like. Is it worth trying to change it
to use PCP_PROG_MAKE and PCP_PROG_ECHO?
On Tue, 8 Jun 2010 15:29:29 +1000 (EST), Nathan Scott wrote:
nathans> Looks good to me, although your choice of git branch name
nathans> doesn't inspire a great deal of confidence. :)
Ah, the laziness is the grease on a wheels of progress - I've got
tired typing
CC="/opt/SunStudioExpress/bin/cc -m64" ./configure
every time I pull new stuff into my tree so I made configure to it for
me.
max
|