Most of these are to allow normal PMNS services to work with
PM_CONTEXT_LOCAL (aka -L as a command line option) in the presence of
both dynamic metrics and derived metrics.
Some review of the pmns.c changes would be welcome ... and good luck
with that one.
I've snuck in some other minor things as well ... bash completion,
constifying fixup, pmlogreduce -T fix
My script for sending this mail seems to have become confused and there
is at least one other pmns fix before all of these that has just been
pushed to my git tree, so trust the tree rather than this email!
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
debian/changelog | 5
src/bashrc/pcp_completion.sh | 2
src/include/pmda.h | 8
src/libpcp/src/connectlocal.c | 13
src/libpcp/src/derive_fetch.c | 6
src/libpcp/src/logutil.c | 4
src/libpcp/src/pmns.c | 539 ++++++++++++++++++++++++-----------------
src/libpcp_pmda/src/callback.c | 4
src/pmdas/mmv/mmv.c | 4
src/pmdas/sample/src/sample.c | 8
src/pmlogreduce/pmlogreduce.c | 15 +
11 files changed, 370 insertions(+), 238 deletions(-)
commit 46b6496e39766185d442bcdd3d59119e6e3348f8
Merge: a1413f7 490f1ef
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 11:54:11 2010 +1000
Merge branch 'localpmda' into dev
commit 490f1ef5141c4c4559ed355e7f8811a087091354
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 11:47:22 2010 +1000
pcp_completion.sh - hide stderr output
Now that things are working again with our mmv friend,
$ pminfo mmv<tab or completion key du jour>
produces
$ pminfo mmv[Wed Apr 28 11:48:58] pminfo(11563) Info: MMV: pminfo: 8
metrics and 2 indoms after reload
.
This change assigns stderr from the nested pminfo -L to /dev/null (I
did not want to spank the info message from the mmv pmda, because it is
indeed useful in other contexts).
commit 0fc07c78b8d9faa395f958b09ba5b326f9172f76
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 11:35:33 2010 +1000
pmlogreduce - fix minor compilation whining from last change
commit d29698c4bc4765a155437266721d51b24230d8cf
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 11:31:04 2010 +1000
Tweak error reporting for PMNS operations
With the PMNS, derived metrics and dynamic metrics all acting as
hiding locations for metrics, one may need to seach in several places
for a metric, and some of these searches may fail and some may work
... untangling the error code spaghetti is a little challenging.
commit 16b262231197380f1305f80e6b270bb6ee1ab49d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 07:52:04 2010 +1000
Make sure PM_ERR_NAME is returned when all options exhausted.
Build failed making help text for indom entries after last round
of changes.
commit 99549e65800d49094c63d175f480b8982a35a58a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 07:29:36 2010 +1000
Rework for PM_CONTEXT_LOCAL PMNS services
Make PM_CONTEXT_LOCAL work like PM_CONTEXT_HOST for metrics that are
visible, and in particular ensure that dynamic metrics and derived
metrics are visible for the PMNS services when using PM_CONTEXT_LOCAL.
This should be enough to make pminfo -L mmv work again after mmv was
converted to using dynamic names in the PMNS.
commit 1ff8afac4f1b63b1fafdcbf7b805936d5fe3382b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Apr 28 07:21:10 2010 +1000
Dynamic names rework after derived metrics added.
The PMID for derived metrics and for the root of a dynamic subtree in
the PMNS both use a domain of DYNAMIC_PMID ... tighten up tests to be
sure that we're not confused and consistently using the following tests:
dynamic root of pmns
pmid_domain(pmid) == DYNAMIC_PMID
|