pcp
[Top] [All Lists]

Re: [pcp] pcp updates - Generalized DSO PMDA support for PM_CONTEXT_LOCA

To: Martin Hicks <mort@xxxxxxx>
Subject: Re: [pcp] pcp updates - Generalized DSO PMDA support for PM_CONTEXT_LOCAL (part 2)
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu, 15 Apr 2010 07:00:00 +1000
Cc: pcp@xxxxxxxxxxx
In-reply-to: <20100414171624.GI19316@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1271133244.24244.160.camel@xxxxxxxxxxxxxxxx> <20100414171624.GI19316@xxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: kenj@xxxxxxxxxxxxxxxx
Thanks Martin.

These are both fixed in my next round of commits.

On Wed, 2010-04-14 at 12:16 -0500, Martin Hicks wrote:
> On Tue, Apr 13, 2010 at 02:34:04PM +1000, Ken McDonell wrote:
> > Second round of changes incorporating Nathan's review comments.
> > 
> 
> The few things I noticed were all cosmetic:
> 
> - pminfo manpage is malformed after the -K blurb

One too many .RE is not good.

> - pmspeclocalpmda.3 mentions that fields are separated by ':'.  Looks
>   like ',' is reality.

Yep it is comma-separated.

Ta.

<Prev in Thread] Current Thread [Next in Thread>