----- "Ken McDonell" <kenj@xxxxxxxxxxxxxxxx> wrote:
> ...
> If that goes well, then these should be ready for merging into the
> main tree, modulo consideration of any review feedback.
>
Looking good. Couple of minor things...
- the error messages in __pmLocalPMDA are using an old name for the
routine (__pmAddLocalPMDA)
- seems like do_pmda_spec() should be a libpcp API, ala the other
parsing routines, since three tools (so far) use it & it is kinda
like one of the "standard" command line options, almost.
- at this stage, we could probably split libpcp/src/connect.c into
a pmcd version and a local version, ala fetch.c & fetchlocal.c.
Here's a patch that addresses these. Its untested (ran out of time
on the train this morning, have to look at other stuff now). The
parseError() code was pulled from the time window parser, might be
time to make that shared too (in libpcp).
cheers.
--
Nathan
localcontext.patch
Description: Text Data
|