Suggest the sgi folk pull these and make the associated changes to the
cluster PMDA so it can use the IB PMDA again.
All you should need there would be (before the pmNewContext() call to
create the PM_CONTEXT_LOCAL connection) ...
sts = __pmLocalPMDA(PM_LOCAL_CLEAR, 0, NULL, NULL);
sts = __pmLocalPMDA(PM_LOCAL_ADD, 91, "ib/pmda_ib", "ib_init");
(and the first of these is optional).
If that goes well, then these should be ready for merging into the main
tree, modulo consideration of any review feedback.
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
Makepkgs | 34 +++++-
man/man1/pminfo.1 | 81 +++++++++++++-
man/man1/pmprobe.1 | 56 +++++++++
man/man1/pmstat.1 | 2
man/man1/pmval.1 | 70 ++++++++++++
man/man3/pmlocalpmda.3 | 139 ++++++++++++++++++++++++
src/include/impl.h | 9 +
src/libpcp/src/GNUmakefile | 14 --
src/libpcp/src/connect.c | 226 +++++++++++++++++++++++++++++++++-------
src/libpcp/src/p_profile.c | 42 ++++++-
src/pminfo/GNUmakefile | 3
src/pminfo/do_local_spec.c | 107 ++++++++++++++++++
src/pminfo/pminfo.c | 36 ++----
src/pmlogextract/pmlogextract.c | 20 +--
src/pmprobe/.gitignore | 1
src/pmprobe/GNUmakefile | 12 +-
src/pmprobe/pmprobe.c | 36 ++----
src/pmstat/pmstat.c | 4
src/pmval/.gitignore | 1
src/pmval/GNUmakefile | 11 +
src/pmval/pmval.c | 10 +
21 files changed, 788 insertions(+), 126 deletions(-)
commit b7d1ee7da124ef434272ffd47ea0fcafaeca9710
Merge: 94a28e4 a1b2d60
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Apr 11 08:10:41 2010 +1000
Merge branch 'localpmda' into dev
commit a1b2d605b25c84e0a6bf402059551a13f61fcd29
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Apr 11 08:08:31 2010 +1000
Generalized DSO PMDA support for PM_CONTEXT_LOCAL
[second commit, this time for all the modified files, duh!]
This batch of changes adds to the existing hardcoded table (and funky
environment variable rules) that control which DSO PMDAs may be used
with PM_CONTEXT_LOCAL.
Specifically, __pmLocalPMDA() is added to libpcp to allow updates to the
table, i.e. add a new entry, delete an existing entry, clear all entries.
The monitoring tools that understand -L from the command line
(pminfo and pmprobe) or support the equivalent @:metric syntax from
pmParseMetricSpec() (pmval) have been given a new command line option,
-K to get access to __pmLocalPMDA(). pmstat groks -L, but the metrics
it uses are hardcoded to the OS PMDA, so there was no point in addding
-K for pmstat.
In the process the #define PM_USE_CONTEXT_LOCAL (which was always set)
was removed from the source allowing some dead code to be removed.
commit a0eb58cf0b14f85f33cb70c4318ee12a07ad089c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Apr 11 07:59:08 2010 +1000
Generalized DSO PMDA support for PM_CONTEXT_LOCAL
This batch of changes adds to the existing hardcoded table (and funky
environment variable rules) that control which DSO PMDAs may be used
with PM_CONTEXT_LOCAL.
Specifically, __pmLocalPMDA() is added to libpcp to allow updates to the
table, i.e. add a new entry, delete an existing entry, clear all entries.
The monitoring tools that understand -L from the command line
(pminfo and pmprobe) or support the equivalent @:metric syntax from
pmParseMetricSpec() (pmval) have been given a new command line option,
-K to get access to __pmLocalPMDA(). pmstat groks -L, but the metrics
it uses are hardcoded to the OS PMDA, so there was no point in addding
-K for pmstat.
In the process the #define PM_USE_CONTEXT_LOCAL (which was always set)
was removed from the source allowing some dead code to be removed.
Some minor clean up of the man pages also was done, e.g. documenting
the -c option for pminfo (hang over from the derived metrics changes).
commit 0b7e3d32354f43f33d1267ca4b9c3ba00db7c3d3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Apr 11 07:50:51 2010 +1000
Grammatical typo.
commit dd38b5b3d11ca1a3c1dbaae20535bf8e8c1d62ee
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Apr 11 07:47:10 2010 +1000
Makepkgs - Ubuntu toolchain problems persist
Comment ahead of new checks says it all ...
Sanity checks ... this is sick, but I'm really tired of QA failing
because of bad binaries being built from the Ubuntu toolchain.
commit e3273a1eabb0225db33b02d6557a6e000358f9f0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Apr 11 06:58:57 2010 +1000
pmlogextract - clean up diagnostics
Report pmid in a more human friendly way, correct an endian issue in
the reported times for log volume changes.
commit 94a28e47f402981fc13de6601a98e94decfa6653
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Mar 27 07:45:45 2010 +1100
p_profile.c better cleanup after failure
First part of a cleanup and DOS defence. Still to come is some "reasonable"
size limits when and if we can agree on "reasonable".
|