On Tue, Jan 12, 2010 at 02:17:47PM +1100, Nathan Scott wrote:
>
> ----- "Martin Hicks" <mort@xxxxxxx> wrote:
>
> > On Mon, Dec 21, 2009 at 05:59:14PM -0600, Martin Hicks wrote:
> > >
> > > I just pushed out an enhancement to the linux PMDA that adds the
> > NUMA
> > > memory statistics from
> > /sys/devices/system/node/node*/{meminfo,numastat}
> > >
>
> FWIW, reviewed it & it looks good.
>
> > I think the only change I need is to return quietly if the node
> > directory isn't present:
>
> *nod* ... current code works fine on my laptop with no numa stats,
> will kick the tyres on a machine with some numa stats too when I
> get a chance.
>
> I tidied up a minor compiler warning after merging in my tree btw,
> just a 32 bit-ism.
Great, thanks for the review Nathan.
mh
|