pcp
[Top] [All Lists]

Re: [pcp] pcp updates

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] pcp updates
From: Martin Hicks <mort@xxxxxxx>
Date: Tue, 20 Oct 2009 15:02:56 -0500
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1256068647.8067.7.camel@xxxxxxxxxxxxxxxx>
References: <20091020191658.GS30151@xxxxxxxxxxxxxxxxxxxxxxxxx> <1256068647.8067.7.camel@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Oct 21, 2009 at 06:57:27AM +1100, Ken McDonell wrote:
> The serial member of __pmInDom_int is 22 bits wide, so 0x3fffff was
> probably correct if it is planning to set all these bits to 1's.

Oh, I got fooled because the cluster PMDA steals four of these bits.
I'll revert that change.

> 
> On Tue, 2009-10-20 at 14:16 -0500, Martin Hicks wrote:
> > The change that I'm not 100% sure about is in commit 1d1ef757
> > where I changed CLUSTER_INDOM.  I *think* it's correct because
> > the serial member of __pmInDom_int is 18 bits wide.
> > 
> > --- a/src/pmdas/cluster/cluster.h
> > +++ b/src/pmdas/cluster/cluster.h
> > @@ -29,7 +29,7 @@
> >  #define CLUSTER_CLIENT_VERSION 101
> >  
> >  /* singular instance domain translation */
> > -#define CLUSTER_INDOM          0x3fffff
> > +#define CLUSTER_INDOM          0x3ffff
> > 
> ...

<Prev in Thread] Current Thread [Next in Thread>