pcp
[Top] [All Lists]

Re: [pcp] A few trivial changes for dynamic subtrees of the PMNS

To: kenj@xxxxxxxxxxxxxxxx
Subject: Re: [pcp] A few trivial changes for dynamic subtrees of the PMNS
From: Mark Goodwin <goodwinos@xxxxxxxxx>
Date: Fri, 02 Oct 2009 14:49:30 +1000
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1254457218.13137.8.camel@xxxxxxxxxxxxxxxxxxxxxxx>
References: <1254457218.13137.8.camel@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

OK I just pulled that in too, for 3.0.1-1 and am now about to
push this all out to the dev branch, along with a qa report.

[mgoodwin@fletch pcp-kenj]$ git pull
remote: Counting objects: 23, done.
remote: Compressing objects: 100% (15/15), done.
remote: Total 15 (delta 13), reused 0 (delta 0)
Unpacking objects: 100% (15/15), done.
From git://oss.sgi.com/kenj/pcp
   4d16113..e29e5c3  master     -> origin/master
Updating 4d16113..e29e5c3
Fast forward
 man/man1/dbpmda.1              |   72 ++++++++++++++++++++++++++++++++++++++++
 src/libpcp_pmda/src/mainloop.c |   11 +-----
 2 files changed, 73 insertions(+), 10 deletions(-)



Ken McDonell wrote:
A couple of minor things I cleaned up ...

Changes committed to git://oss.sgi.com/kenj/pcp.git master

 man/man1/dbpmda.1              |   72 +++++++++++++++++++++++++++++++++++++++++
 src/libpcp_pmda/src/mainloop.c |   11 ------
 2 files changed, 73 insertions(+), 10 deletions(-)

commit e29e5c373f4dadce551c64f9ae616c3a8870c823
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Oct 2 14:08:56 2009 +1000

    libpcp_pmda, dbpmda Minor additions for dynamic subtrees in the PMNS
In libpcp_pmda the wrong error was being returned if an attempt was
    made to translate a dynamic metric name to a PMID, and the PMDA is NOT
    using PMDA_INTERFACE_4 (very low chance of this happening).
And the additional documentation for dbpmda to describe the new commands
    to exercise the services a PMDA needs to provide to play in the dynamic
    subtrees of the PMNS (this was just forgotten in the "final" checkin
    for these changes).

commit a8a2626aa86cf0ec4d03ac761a7cc960af26b2df
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Oct 1 15:32:33 2009 +1000

    libpcp_pmda remove dead code
Call to pmLoadNameSpace() is not needed at was guarded by #if 0.
    Removed code block to reduce confusion.



_______________________________________________
pcp mailing list
pcp@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/pcp

<Prev in Thread] Current Thread [Next in Thread>