Hi Ken,
----- "Ken McDonell" <kenj@xxxxxxxxxxxxxxxx> wrote:
> Committed to the *master* branch of my PCP tree on oss.sgi.com
>
> There are several rounds of commits for this set of changes that
> became
> much more complicated and touched more files than I'd originally
> expected.
>
> This all passes my QA ... after I get some feedback on the PCP
> changes I'll move the QA tree forward.
I've pulled the dynamic PMNS changes out into a separate patch for
reviewing and given it an initial read-through. So far, the only
thing that I've noticed is the (leftover?) commented out TODO in
src/libpcp_pmda/src/mainloop.c where a manual loadnamespace looks
to have been inserted (+ later removed) at some point.
Otherwise it looks pretty good. I wonder if we should be bumping
the libpcp_pmda shared library soname for this change? Also it'd
be good to convert a "real" PMDA like MMV (which it sounds like
you've started from that other mail) - maybe a helper routine or
two might fall out of that that could live in libpcp_pmda, and if
so, good to get those into the library for the dso vesion change.
The patch is at http://oss.sgi.com/~nathans/dynamic_pmns.patch if
others would like to review it standalone too (please do!).
cheers.
--
Nathan
|