Anyone have any opinion on this patch? Seems OK to me, if I don't hear
anything, I'll merge it shortly (before next point release).
thanks.
----- Forwarded Message -----
From: "Petter Reinholdtsen" <pere@xxxxxxxxxx>
To: submit@xxxxxxxxxxxxxxx
Sent: Monday, August 31, 2009 6:37:15 AM GMT +10:00 Canberra / Melbourne /
Sydney
Subject: Bug#544350: pcp: Missing runlevels and dependencies in init.d scripts
Package: pcp
Version: 2.7.4-20080306
Severity: important
Tags: patch
User: initscripts-ng-devel@xxxxxxxxxxxxxxxxxxxxxxx
Usertags: incorrect-dependency incorrect-runlevels
With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts of this package. The list of runlevels to
stop in is incomplete. The script should stop in runlevel 1 to make
sure the service is started again when switching from runlevel 1 to
2-5. Also, the script should probably stop during halt (0) and reboot
(6). The package should start in runlevel 4, just like in runlevels
2, 3 and 5. I suspect the list of dependencies are incomplete. The
scripts used to start after the syslog collector was operational, and
should probably continue to do so. Also, the scripts need files in
/usr/ and should depend on $remote_fs.
If the scripts themselves need to start in any specific order, the
relationship should be listed explicitly in the LSB header too. Make
sure the update-rc.d calls in the postinst reflect this ordering if
any such dependencies should exist.
This patch implement the proposed change. Without it, the script seem
to fail to handle runlevel 0, 1, 4 and 6 properly, and might start to
early in the boot.
diff -ur pcp-2.9.0/src/pmcd/rc_pcp pcp-2.9.0-pere/src/pmcd/rc_pcp
--- pcp-2.9.0/src/pmcd/rc_pcp 2009-07-01 04:32:40.000000000 +0200
+++ pcp-2.9.0-pere/src/pmcd/rc_pcp 2009-08-30 22:29:59.000000000 +0200
@@ -26,10 +26,10 @@
# e.g. SuSE, where chkconfig is a perl script.
### BEGIN INIT INFO
# Provides: pcp
-# Required-Start: $network $local_fs
-# Required-Stop:
-# Default-Start: 2 3 5
-# Default-Stop:
+# Required-Start: $network $remote_fs $syslog
+# Required-Stop: $remote_fs $syslog
+# Default-Start: 2 3 4 5
+# Default-Stop: 0 1 6
# Short-Description: Control pmcd and pmlogger daemons
# Description: Configure the Performance Co-Pilot and starts logging.
### END INIT INFO
diff -ur pcp-2.9.0/src/pmie/rc_pmie pcp-2.9.0-pere/src/pmie/rc_pmie
--- pcp-2.9.0/src/pmie/rc_pmie 2009-04-24 02:20:10.000000000 +0200
+++ pcp-2.9.0-pere/src/pmie/rc_pmie 2009-08-30 22:30:25.000000000 +0200
@@ -20,10 +20,10 @@
# e.g. SuSE, where chkconfig is a perl script.
### BEGIN INIT INFO
# Provides: pmie
-# Required-Start: $network $local_fs
-# Required-Stop:
-# Default-Start: 2 3 5
-# Default-Stop:
+# Required-Start: $network $remote_fs $syslog
+# Required-Stop: $remote_fs $syslog
+# Default-Start: 2 3 4 5
+# Default-Stop: 0 1 6
# Short-Description: Control PCP inference engines
# Description: Configures the performance monitoring inference engine
### END INIT INFO
diff -ur pcp-2.9.0/src/pmproxy/rc_pmproxy pcp-2.9.0-pere/src/pmproxy/rc_pmproxy
--- pcp-2.9.0/src/pmproxy/rc_pmproxy 2009-07-01 04:32:40.000000000 +0200
+++ pcp-2.9.0-pere/src/pmproxy/rc_pmproxy 2009-08-30 22:30:49.000000000
+0200
@@ -26,10 +26,10 @@
# e.g. SuSE, where chkconfig is a perl script.
### BEGIN INIT INFO
# Provides: pmproxy
-# Required-Start: $network $local_fs
-# Required-Stop:
-# Default-Start: 2 3 5
-# Default-Stop:
+# Required-Start: $network $remote_fs $syslog
+# Required-Stop: $remote_fs $syslog
+# Default-Start: 2 3 4 5
+# Default-Stop: 0 1 6
# Short-Description: Control the pmproxy daemon
# Description: Control the Performance Co-Pilot protocol proxy daemon
### END INIT INFO
Happy hacking,
--
Petter Reinholdtsen
--
Nathan
|