Changes committed to git://oss.sgi.com/nathans/pcp.git
src/pmdas/linux/proc_cpuinfo.c | 38 +++++++++++++++++---------------------
src/pmdas/linux/proc_cpuinfo.h | 1 -
src/pmdas/linux/proc_loadavg.c | 7 ++++---
3 files changed, 21 insertions(+), 25 deletions(-)
commit fee86f6503252207a236c5eb81c8d092eede1a87
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jul 16 16:59:45 2009 +1000
Rework the special SGI CPU numbering logic in the Linux PMDA.
This resolves a buffer overflow bug in the use of realpath(3)
in this routine, which was being passed a too-small buffer.
This issue was initially reported to us by Chandana De Silva,
but looks like others have come across it too, e.g.:
https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/384776
I've removed the unused "cname" field from the per-CPU data
structure, and also added some short-circuit logic into this
code so that we bail out of this logic early if no hardware-
graph filesystem paths are detected (which will be the normal
case for most people).
commit 67ae7fd90a32a43bbc97b939e57302556e864459
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jul 16 16:54:11 2009 +1000
Resolve a valgrind reported problem when initing Linux loadavg metric.
Ensure read buffer is initialised to zero, and also check the return
code for a failed read syscall.
|