pcp
[Top] [All Lists]

Re: [PATCH] tmpfs metrics

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] tmpfs metrics
From: Martin Hicks <mort@xxxxxxx>
Date: Fri, 22 May 2009 13:19:48 -0500
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1450490639.5302301242951265466.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <1826885076.5302261242951238548.JavaMail.root@xxxxxxxxxxxxxxxxxx> <1450490639.5302301242951265466.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri, May 22, 2009 at 10:14:25AM +1000, Nathan Scott wrote:
> Hacked this up last night - resolves bugzilla bug #823.
> Could you give it a quick review?

Looks good to me.  I even tested it on an ICE cluster with the cluster
pmda.  Very nice.

r1lead:~ # pminfo -f cluster.tmpfs.full

cluster.tmpfs.full
    inst [0 or "r1i0n8-0 /dev"] value 0.01101056606543539
    inst [1 or "r1i0n8-1 /tmp"] value 0
    inst [2 or "r1i0n0-0 /dev"] value 0.01101056606543539
    inst [3 or "r1i0n0-1 /tmp"] value 3.111979166666667


mh

<Prev in Thread] Current Thread [Next in Thread>