pcp
[Top] [All Lists]

setting pcp_rc_dir in configure.in

To: pcp@xxxxxxxxxxx
Subject: setting pcp_rc_dir in configure.in
From: Jason Rappleye <jason.rappleye@xxxxxxxx>
Date: Fri, 15 May 2009 19:21:33 -0700
Hi,

configure.in defines pcp_rc_dir by testing for the existence of the directories /etc/rc.d/init.d /etc/init.d /sbin/init.d, and setting pcp_rc_dir to the first one it finds.

We run SLES on our systems, and what I'll call a "rogue" RPM happened to create /etc/rc.d/init.d and install an init script there on the host I did my pcp build on. This makes chkconfig unhappy, as it expects to find init scripts in /etc/init.d.

Arguably /etc/rc.d/init.d shouldn't be present on a SuSE machine, but nonetheless, I think it would be a good idea to explicitly set pcp_rc_dir to /etc/init.d for SuSE. Might be a good idea to do the same for other distros as well. The following patch should do the trick, though I've only been able to test on SLES 10 SP2.

Thanks,

j

diff --git a/configure.in b/configure.in
index 096e622..b094240 100644
--- a/configure.in
+++ b/configure.in
@@ -1500,8 +1500,13 @@ fi
 AC_SUBST(pcp_inc_dir)

 dnl rc/startup files
-if test $target_os != darwin
+if test $target_os = darwin
 then
+    pcp_rc_dir=/Library/StartupItems/pcp
+elif test $target_distro = suse
+then
+    pcp_rc_dir=/etc/init.d
+else
     for d in /etc/rc.d/init.d /etc/init.d /sbin/init.d ; do
        if test -d $d
        then
@@ -1513,8 +1518,6 @@ then
     then
        pcp_rc_dir=/etc
     fi
-else
-    pcp_rc_dir=/Library/StartupItems/pcp
 fi
 AC_SUBST(pcp_rc_dir)


--
Jason Rappleye
System Administrator
NASA Advanced Supercomputing Division
NASA Ames Research Center
Moffett Field, CA 94035
(650) 604-2875
jason.rappleye@xxxxxxxx



<Prev in Thread] Current Thread [Next in Thread>