----- "Martin Hicks" <mort@xxxxxxx> wrote:
> In the linux PMDA. Any complaints with this patch?
>
> The changes at the beginning just get rid of whitespace annoyances.
> The last two hunks are what fix the problem.
Good catch!
> @@ -75,7 +75,7 @@ refresh_filesys_projects(pmInDom qindom, filesys_t
> *fs)
> qp = NULL;
> sts = pmdaCacheLookupName(qindom, p, NULL, (void **)&qp);
> if (sts == PMDA_CACHE_ACTIVE) /* repeated line in
> /etc/projects? */
> - continue;
> + goto next;
> if (sts != PMDA_CACHE_INACTIVE) {
> qp = (project_t *)malloc(sizeof(project_t));
This malloc return code is unchecked too - the filesys code
further on just (silently) continues on this class of error,
guess we should do the same thing here (well, "goto next" on
a NULL "qp") as SIGSEGV here would take out pmcd.
cheers.
--
Nathan
|