pcp
[Top] [All Lists]

pcp updates (win32)

To: pcp@xxxxxxxxxxx
Subject: pcp updates (win32)
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Fri, 1 May 2009 17:11:29 +1000 (EST)
Changes committed to git://oss.sgi.com/nathans/pcp.git

 src/include/impl.h           |   12 --
 src/libpcp/src/logportmap.c  |   24 ++---
 src/pmdas/windows/instance.c |    7 +
 src/pmdas/windows/open.c     |   23 +++--
 src/pmdas/windows/pdhlist.c  |   75 ++++++----------
 src/pmdas/windows/pmda.c     |  194 +++++++++++++++++++++----------------------
 src/pmlogger/ports.c         |   35 ++-----
 7 files changed, 169 insertions(+), 201 deletions(-)

commit 4ea2709b00af1015f9757837eb7bd5254ecfa101
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:52:21 2009 +1000

    Use generic PdhExpandCounter regexs for Windows metrics with indoms.
    
    After initial testing, this seems to work for both Windows Server
    2003 and 2008.  More testing needed, but pmdawindows is now much
    more stable for me on 2008, so push the change in for others.
    This might well resolve some of the pmdawindows issues Chatz saw
    on some desktop Windows variants as well (XP IIRC).

commit 1bed5b2f5983fd4ff2bf552ded03f2fa0a328efa
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:43:41 2009 +1000

    Make the code which expands Windows metric names more robust.

commit e2dec6afb26de16247a1022a37f2f79d4bef202c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:42:57 2009 +1000

    Tweaks to instance domain parsing for Windows 2008.

commit e52d51f497c74b288f4fee985c78a8939e274b2b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:36:30 2009 +1000

    pdhlist uses new metric name regex always now (works for W2K3 too).

commit af890048870947ce420ac287e896f8851b626f61
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:28:16 2009 +1000

    Extend the Windows pdhlist.c utility sources for Windows testing.
    
    At some point between Windows Server 2003 and 2008 the regular
    expression syntax for the PdhExpandCounterPath has mutated.  Still
    figuring out the exact extent of this, but it prevents the Windows
    PMDA metrics with instances from functioning at all currently, due
    to the old regexs for those no longer being accepted.  This change
    extends a diagnostic utility to better assist this exercise.

commit 8c5763fda6b77e16bcd21ef4ad260333edb95300
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:11:00 2009 +1000

    After freeing a value set pointer, set it to NULL for realloc.
    
    This was causing havoc in the Windows PMDA under Windows Server
    2008, as random memory corruption would result in realloc.

commit 3c5c3646fff527e90d93bffaec79b916630575ac
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri May 1 16:08:52 2009 +1000

    Rework the pmlogger control file path handling.
    
    Remove PM_LOG_PORT_DIR and PM_LOG_PRIMARY_LINK macros.  These
    hard-coded POSIX paths to /var/tmp, now we use PCP_TMP_DIR and
    Win32 gets a fighting chance.  Some of the earlier Windows code
    is then able to be removed and/or simplified.
    
    Win32 scandir returns an error on ENOENT too, so handle that.

<Prev in Thread] Current Thread [Next in Thread>