pcp
[Top] [All Lists]

pmnewlog quirk

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: pmnewlog quirk
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Mon, 02 Mar 2009 13:43:20 +1100
Cc: pcp@xxxxxxxxxxx
Hi Ken,

I came across a slight oddity in pmnewlog - it has code like this:

...
# kill off existing pmlogger
#
$VERBOSE && $PCP_ECHO_PROG $PCP_ECHO_N "Terminating
$myname ...""$PCP_ECHO_C"
for sig in INT HUP KILL
do
    $VERBOSE && $PCP_ECHO_PROG $PCP_ECHO_N " SIG$sig ...""$PCP_ECHO_C"
    eval $KILL -s $sig $pid
    sleep 5
    [ "`_check_pid $pid`" = "" ] && break
done


Now SIGHUP is "start a new volume" in pmlogger, SIGINT is "exit".
Is that SIGHUP supposed to be there?  Seems pretty random as to
whether it will ever get called.  Should we flush first?  (SIGUSR1)
Was that the original intention there?  SIGINT just unlinks control
files and then exits... seems like maybe we should do an flush too?
(IOW should I change the signal list to "flush, exit, force-exit"?)

Thanks!

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>