pcp
[Top] [All Lists]

Re: [pcp] Updates

To: Martin Hicks <mort@xxxxxxx>
Subject: Re: [pcp] Updates
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Sat, 14 Feb 2009 10:18:47 +1100
Cc: pcp@xxxxxxxxxxx
In-reply-to: <20090213202902.GV20819@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20090213202902.GV20819@xxxxxxxxxxxxxxxxxxxxxxxxx>
On Fri, 2009-02-13 at 14:29 -0600, Martin Hicks wrote:
> I've created my own tree on oss.  I'll be pushing patches here before I
> commit them to the real git tree, to give the community time to review.

Good stuff... will have a look soon.  At first glance, I was
looking for a pmdacluster / pmclusterd man page ... do those
exist anywhere yet?

> I'm particularly curious about the patch below that I got from Michael
> Newton.  I presume it is a real bugfix, but I don't understand this area
> of the code yet...

BTW, you can set author attribution (i.e. the user name and
email address for a commit) using the environment variables
GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL.  In our case, the Linux
kernel "Signed-off-by:" lines are a bit of overkill IMO ...
we don't have the long chains of command where code is passed
up the line via several people before it hits mainline.

>  src/pmdas/cluster/etc_init.d_pmclusterd |  237 +++++++++

These scripts tend to be named rc_* nowadays...

$ ls ../../*/rc_*
../../pmcd/rc_local  ../../pmie/rc_pmie
../../pmcd/rc_pcp    ../../pmproxy/rc_pmproxy

I'll have a look through the code & do a proper review next week.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>