pcp
[Top] [All Lists]

Re: [pcp] PCP bugs found so far at LCA

To: Max Matveev <makc@xxxxxxxxx>
Subject: Re: [pcp] PCP bugs found so far at LCA
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Thu, 22 Jan 2009 11:57:57 +1100
Cc: pcp@xxxxxxxxxxx
In-reply-to: <18806.61597.987693.26@xxxxxxxxxxxxxxxxx>
References: <1232520766.5136.13.camel@xxxxxxxxxxxxxxxxxx> <18806.61597.987693.26@xxxxxxxxxxxxxxxxx>
On Wed, 2009-01-21 at 20:53 +1100, Max Matveev wrote:
> On Wed, 21 Jan 2009 17:52:46 +1100, Nathan Scott wrote:
> 
>  nscott> - Makepkgs doesn't work if /bin/sh is /bin/dash (something to
>  nscott> do with sourcing the VERSION file).
> 
> This is the Debian Shell, i.e. not a typo from bash?

http://gondor.apana.org.au/~herbert/dash/ ... this particular
person was running Ubuntu, so quite possibly this is only used
on Debian & its derivatives.

> IIRC it was derived from ash and, equally IIRC, ash was working which,
> at least to me, suggests a dash problem, neh?

>From a quick look, it seems like dash doesn't handle the implied
pwd when sourcing the VERSION file (what the?!) ...

$ dash -x Makepkgs
...
+ echo == Building pcp, log is in Logs/pcp
== Building pcp, log is in Logs/pcp
+ . VERSION.pcp
.: 1: VERSION.pcp: not found
+ rm -f /tmp/8315.*

Hohum.  This "fixes" it...

$ diff --git a/Makepkgs b/Makepkgs
index 358b87b..fe4c126 100755
--- a/Makepkgs
+++ b/Makepkgs
@@ -89,7 +89,7 @@ for prod ; do
     echo
     echo "== Building $prod, log is in $LOGF"
 
-    . VERSION.$prod
+    . ./VERSION.$prod
 
     if [ "$prod" = "pro" ]
     then


Bizzare.  But, this seems to be a default shell for some installs...
so guess we may as well fix it up.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>