I've looked at the first one.
I can PROVE mathematically, that sts at line 453 of connect.c MUST be
initialized in all cases.
This appears to be a case of some "still young enough to know
everything" gcc zealot who has cocked the whole thing up. My
recommendation is to not upgrade gcc, and leave the PCP source alone.
On Fri, 2008-04-18 at 13:48 +1000, Nathan Scott wrote:
> Just upgraded gcc to ...
>
> 13:47 nathans@edge /source/git/pcp 7> gcc --version
> gcc (GCC) 4.2.3 (Debian 4.2.3-3)
>
> and, wheee, tons of shiny new warnings to work through, if
> anyone's feeling brave...
>
> connect.c: In function ‘__pmConnectPMCD’:
> connect.c:453: warning: ‘sts’ is used uninitialized in this function
> connect.c:325: warning: ‘fd’ may be used uninitialized in this function
> p_instance.c: In function ‘__pmDecodeInstance’:
> p_instance.c:216: warning: ‘rp’ may be used uninitialized in this
> function
> p_result.c: In function ‘__pmDecodeResult’:
> p_result.c:224: warning: ‘i’ may be used uninitialized in this function
> p_pmns.c: In function ‘__pmDecodeNameList’:
> p_pmns.c:304: warning: ‘status’ may be used uninitialized in this
> function
> pmns.c: In function ‘load’:
> pmns.c:2159: warning: ‘np’ may be used uninitialized in this function
> pmns.c:2159: note: ‘np’ was declared here
> pmns.c: In function ‘pmGetChildrenStatus’:
> pmns.c:3084: warning: ‘newname’ may be used uninitialized in this
> function
> pmns.c: In function ‘pmTraversePMNS’:
> pmns.c:3565: warning: ‘namelist’ may be used uninitialized in this
> function
> units.c: In function ‘pmUnitsStr’:
> units.c:122: warning: ‘spacestr’ may be used uninitialized in this
> function
> units.c:123: warning: ‘timestr’ may be used uninitialized in this
> function
> units.c:124: warning: ‘countstr’ may be used uninitialized in this
> function
> util.c: In function ‘pmflush’:
> util.c:899: warning: ‘eptr’ may be used uninitialized in this function
> logutil.c: In function ‘__pmGetArchiveEnd’:
> logutil.c:1947: warning: ‘physend’ may be used uninitialized in this
> function
> logutil.c:1937: warning: ‘save’ may be used uninitialized in this
> function
> interp.c: In function ‘__pmLogFetchInterp’:
> interp.c:499: warning: ‘pcp’ may be used uninitialized in this function
> rtime.c: In function ‘pmParseTimeWindow’:
> rtime.c:614: warning: ‘delta’ may be used uninitialized in this function
> spec.c: In function ‘pmParseMetricSpec’:
> spec.c:93: warning: ‘a_end’ may be used uninitialized in this function
> spec.c:97: warning: ‘i_end’ may be used uninitialized in this function
> optfetch.c: In function ‘__pmOptFetchAdd’:
> optfetch.c:369: warning: ‘pmp’ may be used uninitialized in this
> function
> callback.c: In function ‘pmdaInstance’:
> callback.c:220: warning: ‘idp’ may be used uninitialized in this
> function
> pmnsmerge.c: In function ‘addpmns’:
> pmnsmerge.c:122: warning: ‘lastp’ may be used uninitialized in this
> function
> pmnsdel.c: In function ‘delpmns’:
> pmnsdel.c:52: warning: ‘lastp’ may be used uninitialized in this
> function
> pminfo.c: In function ‘report’:
> pminfo.c:144: warning: ‘vsp’ may be used uninitialized in this function
> pmnscomp.c: In function ‘main’:
> pmnscomp.c:235: warning: ‘startsum’ may be used uninitialized in this
> function
> config.c: In function ‘CreateAgent’:
> config.c:1532: warning: ‘argv’ may be used uninitialized in this
> function
> config.c: In function ‘ContactAgents’:
> config.c:1956: warning: ‘sts’ may be used uninitialized in this function
> dopdus.c: In function ‘DoInstance’:
> dopdus.c:303: warning: ‘fdfail’ may be used uninitialized in this
> function
> dopdus.c: In function ‘DoDesc’:
> dopdus.c:224: warning: ‘fdfail’ may be used uninitialized in this
> function
> pmie.c: In function ‘load’:
> pmie.c:206: warning: ‘sts’ may be used uninitialized in this function
> symbol.c: In function ‘symIntern’:
> symbol.c:134: warning: ‘scoop’ may be used uninitialized in this
> function
> dstruct.c: In function ‘instExpr’:
> dstruct.c:713: warning: ‘u.scaleSpace’ may be used uninitialized in this
> function
> dstruct.c:713: warning: ‘u.scaleTime’ may be used uninitialized in this
> function
> dstruct.c:713: warning: ‘u.scaleCount’ may be used uninitialized in this
> function
> dstruct.c:713: warning: ‘u.pad’ may be used uninitialized in this
> function
> show.c: In function ‘lookupHostInst’:
> show.c:155: warning: ‘dbg_dump’ may be used uninitialized in this
> function
> andor.c: In function ‘cndAnd_n_n’:
> andor.c:266: warning: ‘ip2’ may be used uninitialized in this function
> pmprobe.c: In function ‘main’:
> pmprobe.c:99: warning: ‘host’ may be used uninitialized in this function
> pmprobe.c:89: warning: ‘fetch_sts’ may be used uninitialized in this
> function
> pmval.c: In function ‘main’:
> pmval.c:564: warning: ‘tmp_mode’ is used uninitialized in this function
> pmval.c:1515: note: ‘tmp_mode’ was declared here
> pmval.c:1545: warning: ‘idx2’ may be used uninitialized in this function
> pmlogger.c: In function ‘do_dialog’:
> pmlogger.c:325: warning: ‘msgf’ may be used uninitialized in this
> function
> callback.c: In function ‘log_callback’:
> callback.c:336: warning: ‘pdu_last_pmid’ may be used uninitialized in
> this function
> callback.c:335: warning: ‘pdu_first_pmid’ may be used uninitialized in
> this function
> <stdout>:1438: warning: ‘yyunput’ defined but not used
> gram.y: In function ‘dometric’:
> gram.y:397: warning: ‘sts’ may be used uninitialized in this function
> pmlogger.o: In function `do_dialog':
> /source/build/pcp-2.7.4/src/pmlogger/pmlogger.c:412: warning: the use of
> `tmpnam' is dangerous, better use `mkstemp'
> pmdumplog.c: In function ‘main’:
> pmdumplog.c:363: warning: ‘rawfile’ may be used uninitialized in this
> function
> pmdumplog.c:225: warning: ‘log_size’ may be used uninitialized in this
> function
> pmdumplog.c:225: note: ‘log_size’ was declared here
> pmdumplog.c:224: warning: ‘meta_size’ may be used uninitialized in this
> function
> pmdumplog.c:224: note: ‘meta_size’ was declared here
> metriclist.c: In function ‘searchmlist’:
> metriclist.c:198: warning: ‘vlistp’ may be used uninitialized in this
> function
> <stdout>:1163: warning: ‘yyunput’ defined but not used
> pmstore.c: In function ‘main’:
> pmstore.c:290: warning: ‘host’ may be used uninitialized in this
> function
> pmstore.c:301: warning: ‘aggr_len’ may be used uninitialized in this
> function
> pmlogsummary.c: In function ‘main’:
> pmlogsummary.c:661: warning: ‘rate’ may be used uninitialized in this
> function
> pmlogsummary.c:661: note: ‘rate’ was declared here
> pmclient.c: In function ‘main’:
> pmclient.c:261: warning: ‘host’ may be used uninitialized in this
> function
> pmkstat.c: In function ‘main’:
> pmkstat.c:99: warning: ‘host’ may be used uninitialized in this function
> pmkstat.c:112: warning: ‘lastdkwrite’ may be used uninitialized in this
> function
> pmkstat.c:111: warning: ‘lastdkread’ may be used uninitialized in this
> function
> pmkstat.c:107: warning: ‘prev’ may be used uninitialized in this
> function
> pmlc.c: In function ‘main’:
> pmlc.c:80: warning: ‘sts’ may be used uninitialized in this function
> actions.c: In function ‘Status’:
> actions.c:601: warning: ‘size’ may be used uninitialized in this
> function
> actions.c:600: warning: ‘vol’ may be used uninitialized in this function
> actions.c:599: warning: ‘state’ may be used uninitialized in this
> function
> actions.c:598: warning: ‘hostname’ may be used uninitialized in this
> function
> actions.c:597: warning: ‘timenow’ may be used uninitialized in this
> function
> actions.c:596: warning: ‘last’ may be used uninitialized in this
> function
> actions.c:595: warning: ‘start’ may be used uninitialized in this
> function
> actions.c:594: warning: ‘tzlogger’ may be used uninitialized in this
> function
> actions.c: In function ‘ShowLoggers’:
> actions.c:214: warning: ‘pport’ may be used uninitialized in this
> function
> <stdout>:1487: warning: ‘yyunput’ defined but not used
> dso.c: In function ‘dodso’:
> dso.c:215: warning: ‘desc_list’ may be used uninitialized in this
> function
> dso.c:213: warning: ‘sts’ may be used uninitialized in this function
> pmda.c: In function ‘fillResult’:
> pmda.c:504: warning: ‘nbyte’ may be used uninitialized in this function
> pmda.c: In function ‘dopmda’:
> pmda.c:268: warning: ‘desc_list’ may be used uninitialized in this
> function
> <stdout>:1632: warning: ‘yyunput’ defined but not used
> pmstat.c: In function ‘cntDiff’:
> pmstat.c:103: warning: ‘diff’ may be used uninitialized in this function
> pmcd.c: In function ‘pmcd_instance’:
> pmcd.c:649: warning: ‘nports’ may be used uninitialized in this function
> pmcd.c:651: warning: ‘pmiecount’ may be used uninitialized in this
> function
> pmcd.c:648: warning: ‘getname’ may be used uninitialized in this
> function
> pmcd.c: In function ‘pmcd_fetch’:
> pmcd.c:915: warning: ‘dp’ may be used uninitialized in this function
> weblog.c: In function ‘web_fetch’:
> weblog.c:2530: warning: ‘m_type’ may be used uninitialized in this
> function
> weblog.c:2529: warning: ‘m_offset’ may be used uninitialized in this
> function
> txrecord.c: In function ‘main’:
> txrecord.c:44: warning: ‘sp’ may be used uninitialized in this function
> telnet.c: In function ‘grab_cisco’:
> telnet.c:338: warning: ‘skip’ may be used uninitialized in this function
> probe.c: In function ‘main’:
> probe.c:118: warning: ‘name’ may be used uninitialized in this function
> probe.c:118: note: ‘name’ was declared here
> probe.c:117: warning: ‘ctype’ may be used uninitialized in this function
> probe.c:117: note: ‘ctype’ was declared here
> probe.c:113: warning: ‘defer’ may be used uninitialized in this function
> probe.c:113: note: ‘defer’ was declared here
> jstat.c: In function ‘jstat_indom_check’:
> jstat.c:410: warning: ‘sts’ is used uninitialized in this function
> jstat.c: In function ‘jstat_refresh’:
> jstat.c:593: warning: ‘error’ is used uninitialized in this function
> linuxlnk.c: In function ‘SetBaudCOM’:
> linuxlnk.c:380: warning: ‘baud’ may be used uninitialized in this
> function
> telnet-probe.c: In function ‘main’:
> telnet-probe.c:35: warning: ‘port’ may be used uninitialized in this
> function
>
>
|