Hi Olivier,
> Here is a little patch that add an anti aliasing option per graph. The
> option is also saved in the view.
>
> See attached patch and saved view...
I found a couple of minor issues in the patch, but fixed 'em up and merged
it. Could you double-check it all for me please? The issues were mainly to
do with the view open/save code:
- initial parsing code which detects the "antialiasing" keyword, then
reads the
next word, mishandles the error case of neither on/off ("w" varaiable
could be
NULL after that, and we don't jump out to "abort_chart" we continue on and
dereference "w" - which would sigsegv)
- it seems we default to anti-aliased mode enabled (which is consistent with
current behaviour, so thats good), but in the view save code we only save the
antialiasing keyword if its enabled. which would effectively mean it cant be
used from a saved view config (since only default behaviour was saved) - your
test view only tested the "on" behaviour unfortunately, so missed this.
The .ui file changes needed a bit of tweaking too to work with QT4.2 - but no
big deal, and nothing you can do about that - thats my problem for using an
older Qt version.
One other note about the test view config - its better where possible to make
use of metrics from the sample PMDA, rather than kernel metrics. This allows
me to test it on my Mac as well as on my Linux machines easily - many of the
kernel metrics are different between MacOSX and Linux, whereas the sample
PMDA was specifically designed for testing stuff, and is always the same
across
different platforms.
I've reworked your test view config to use sample metrics and to test both
the
explicit on and off cases (the implicit on case is tested in lots of other
places,
of course). To get the sample PMDA running, do:
# cd /var/lib/pcp/pmdas/sample
# ./Install < /dev/null
Anyway, its merged in - please check it and lemme know if anything is amiss,
thanks!
cheers.
--
Nathan
|